chore: address review comments

Author: dervoeti

CHANGELOG.md

@@ -6,10 +6,9 @@ All notable changes to this project will be documented in this file.
 
 ### Changed
 
+- BREAKING: `configOverrides` now only accepts the supported config file names `hive-site.xml` and `security.properties`. Previously arbitrary keys were silently accepted but ignored ([#695]).
 - Document Helm deployed RBAC permissions and remove unnecessary permissions ([#693]).
 - Bump `stackable-operator` to 0.110.0 and `kube` to 3.1.0 ([#695]).
-  - Replace untyped config overrides with typed `HiveConfigOverrides` for `hive-site.xml` and `security.properties`.
-  - Require explicit `SecretClassVolumeProvisionParts` when provisioning secret volumes.
 
 [#693]: https://github.com/stackabletech/hive-operator/pull/693
 [#695]: https://github.com/stackabletech/hive-operator/pull/695

rust/operator-binary/src/crd/mod.rs

@@ -62,7 +62,7 @@ impl KeyValueOverridesProvider for HiveConfigOverrides {
     fn get_key_value_overrides(&self, file: &str) -> BTreeMap<String, Option<String>> {
         match file {
             HIVE_SITE_XML => self
-                .hive_site
+                .hive_site_xml
                 .as_ref()
                 .map(KeyValueConfigOverrides::as_product_config_overrides)
                 .unwrap_or_default(),
@@ -76,15 +76,6 @@ impl KeyValueOverridesProvider for HiveConfigOverrides {
     }
 }
 
-pub type HiveRoleType = Role<
-    MetaStoreConfigFragment,
-    HiveConfigOverrides,
-    v1alpha1::HiveMetastoreRoleConfig,
-    JavaCommonConfig,
->;
-
-pub type HiveRoleGroupType = RoleGroup<MetaStoreConfigFragment, JavaCommonConfig, HiveConfigOverrides>;
-
 pub const FIELD_MANAGER: &str = "hive-operator";
 pub const APP_NAME: &str = "hive";
 
@@ -122,6 +113,16 @@ pub const DB_PASSWORD_ENV: &str = "DB_PASSWORD_ENV";
 
 const DEFAULT_METASTORE_GRACEFUL_SHUTDOWN_TIMEOUT: Duration = Duration::from_minutes_unchecked(5);
 
+pub type HiveRoleType = Role<
+    MetaStoreConfigFragment,
+    HiveConfigOverrides,
+    v1alpha1::HiveMetastoreRoleConfig,
+    JavaCommonConfig,
+>;
+
+pub type HiveRoleGroupType =
+    RoleGroup<MetaStoreConfigFragment, JavaCommonConfig, HiveConfigOverrides>;
+
 #[derive(Snafu, Debug)]
 pub enum Error {
     #[snafu(display("no metastore role configuration provided"))]
@@ -284,11 +285,7 @@ impl v1alpha1::HiveCluster {
             }))
     }
 
-    pub fn role(
-        &self,
-        role_variant: &HiveRole,
-    ) -> Result<&HiveRoleType, Error>
-    {
+    pub fn role(&self, role_variant: &HiveRole) -> Result<&HiveRoleType, Error> {
         match role_variant {
             HiveRole::MetaStore => self.spec.metastore.as_ref(),
         }