fix: Set restarter label on StatefulSets, not on Pods (#932)

* fix: Set restarter label on StatefulSets, not on Pods

* changelog

Author: sbernauer

CHANGELOG.md

@@ -9,7 +9,7 @@ All notable changes to this project will be documented in this file.
 - Support objectOverrides using `.spec.objectOverrides`.
   See [objectOverrides concepts page](https://docs.stackable.tech/home/nightly/concepts/overrides/#object-overrides) for details ([#927]).
 - Added experimental support for `4.1.1` ([#929])
-- Enable the [restart-controller](https://docs.stackable.tech/home/nightly/commons-operator/restarter/), so that the Pods are automatically restarted on config changes ([#930]).
+- Enable the [restart-controller](https://docs.stackable.tech/home/nightly/commons-operator/restarter/), so that the Pods are automatically restarted on config changes ([#930], [#932]).
 
 ### Changed
 
@@ -29,6 +29,7 @@ All notable changes to this project will be documented in this file.
 [#927]: https://github.com/stackabletech/kafka-operator/pull/927
 [#929]: https://github.com/stackabletech/kafka-operator/pull/929
 [#930]: https://github.com/stackabletech/kafka-operator/pull/930
+[#932]: https://github.com/stackabletech/kafka-operator/pull/932
 
 ## [25.11.0] - 2025-11-07
 

rust/operator-binary/src/resource/statefulset.rs

@@ -427,7 +427,6 @@ pub fn build_broker_rolegroup_statefulset(
     let metadata = ObjectMetaBuilder::new()
         .with_recommended_labels(recommended_object_labels)
         .context(MetadataBuildSnafu)?
-        .with_label(RESTART_CONTROLLER_ENABLED_LABEL.to_owned())
         .build();
 
     if let Some(listener_class) = merged_config.listener_class() {
@@ -525,6 +524,7 @@ pub fn build_broker_rolegroup_statefulset(
                 &rolegroup_ref.role_group,
             ))
             .context(MetadataBuildSnafu)?
+            .with_label(RESTART_CONTROLLER_ENABLED_LABEL.to_owned())
             .build(),
         spec: Some(StatefulSetSpec {
             pod_management_policy: Some("Parallel".to_string()),
@@ -836,6 +836,7 @@ pub fn build_controller_rolegroup_statefulset(
                 &rolegroup_ref.role_group,
             ))
             .context(MetadataBuildSnafu)?
+            .with_label(RESTART_CONTROLLER_ENABLED_LABEL.to_owned())
             .build(),
         spec: Some(StatefulSetSpec {
             pod_management_policy: Some("Parallel".to_string()),

tests/templates/kuttl/smoke-kraft/30-assert.yaml.j2

@@ -7,6 +7,9 @@ apiVersion: apps/v1
 kind: StatefulSet
 metadata:
   name: test-kafka-broker-default
+  generation: 1 # There should be no unneeded Pod restarts
+  labels:
+    restarter.stackable.tech/enabled: "true"
 status:
   readyReplicas: 1
   replicas: 1
@@ -15,6 +18,9 @@ apiVersion: apps/v1
 kind: StatefulSet
 metadata:
   name: test-kafka-broker-automatic-log-config
+  generation: 1 # There should be no unneeded Pod restarts
+  labels:
+    restarter.stackable.tech/enabled: "true"
 status:
   readyReplicas: 1
   replicas: 1
@@ -23,6 +29,9 @@ apiVersion: apps/v1
 kind: StatefulSet
 metadata:
   name: test-kafka-broker-custom-log-config
+  generation: 1 # There should be no unneeded Pod restarts
+  labels:
+    restarter.stackable.tech/enabled: "true"
 status:
   readyReplicas: 1
   replicas: 1
@@ -31,6 +40,9 @@ apiVersion: apps/v1
 kind: StatefulSet
 metadata:
   name: test-kafka-controller-automatic-log-config
+  generation: 1 # There should be no unneeded Pod restarts
+  labels:
+    restarter.stackable.tech/enabled: "true"
 status:
   readyReplicas: 1
   replicas: 1
@@ -39,6 +51,9 @@ apiVersion: apps/v1
 kind: StatefulSet
 metadata:
   name: test-kafka-controller-custom-log-config
+  generation: 1 # There should be no unneeded Pod restarts
+  labels:
+    restarter.stackable.tech/enabled: "true"
 status:
   readyReplicas: 1
   replicas: 1