fix linter

Author: Juan Jesús Padrón Hernández

internal/cmd/alpha/sca/application/create/create_test.go

@@ -271,7 +271,6 @@ func TestParseInput(t *testing.T) {
 		{
 			desc: "invalid max instances",
 			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
-				// scalingTypeFlag.Set()
 				flagValues[scalingTypeFlag.Name()] = scalingTypeAuto
 				delete(flagValues, instancesFlag)
 				flagValues[minInstancesFlag] = "2"
@@ -283,7 +282,6 @@ func TestParseInput(t *testing.T) {
 		{
 			desc: "missing rps and concurrency if autoscaling is enabled",
 			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
-				// scalingTypeFlag.Set()
 				flagValues[scalingTypeFlag.Name()] = scalingTypeAuto
 				delete(flagValues, instancesFlag)
 				flagValues[minInstancesFlag] = "2"

internal/cmd/alpha/sca/application/delete/delete.go

@@ -68,7 +68,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
 
 			environmentLabel, err := utils.GetEnvironmentName(ctx, apiClient.DefaultAPI, model.ProjectId, model.EnvironmentID)
 			if err != nil {
-				params.Printer.Debug(print.ErrorLevel, "get environemnt name: %v", err)
+				params.Printer.Debug(print.ErrorLevel, "get environment name: %v", err)
 				environmentLabel = model.EnvironmentID
 			}
 

internal/cmd/alpha/sca/application/describe/describe.go

@@ -98,7 +98,7 @@ func outputResult(p *print.Printer, outputFormat string, application *sca.Applic
 		table.AddRow("STATE", scautils.ApplicationStateToStr(application.GetStopped()))
 		table.AddSeparator()
 		if application.RuntimeStatus != nil {
-			table.AddRow("AVAILABE INSTANCES", len(application.GetRuntimeStatus().Instances))
+			table.AddRow("AVAILABLE INSTANCES", len(application.GetRuntimeStatus().Instances))
 			table.AddSeparator()
 		}
 		table.AddRow("PUBLIC INGRESS", application.GetNetwork().PublicIngress)
@@ -132,17 +132,17 @@ func outputResult(p *print.Printer, outputFormat string, application *sca.Applic
 
 		environmentVarTables := []tables.Table{}
 		for _, c := range application.Containers {
-			envVarTable := buildEnvVarsTable(c)
+			envVarTable := buildEnvVarsTable(&c)
 			if envVarTable != nil {
 				environmentVarTables = append(environmentVarTables, *envVarTable)
 			}
 			commands := "-"
 			if len(c.Command) > 0 {
 				commands = strings.Join(c.Command, " ")
 			}
-			args := "-"
+			cArgs := "-"
 			if len(c.Command) > 0 {
-				args = strings.Join(c.Args, " ")
+				cArgs = strings.Join(c.Args, " ")
 			}
 
 			cpu := "-"
@@ -161,7 +161,7 @@ func outputResult(p *print.Printer, outputFormat string, application *sca.Applic
 				cpu,
 				memory,
 				commands,
-				args,
+				cArgs,
 			)
 		}
 		tablesToDisplay = append(tablesToDisplay, containersTable)
@@ -233,7 +233,6 @@ func buildScalingRulesTable(rules []sca.ScaleRule) tables.Table {
 			}
 			for _, p := range rule.GetCustomRule().Parameters {
 				params = append(params, fmt.Sprintf("%s: %s", p.Name, p.Value))
-
 			}
 			parameters = strings.Join(params, "\n")
 			sm := make([]string, 0, len(rule.GetCustomRule().SecretsMapping))
@@ -257,7 +256,7 @@ func buildScalingRulesTable(rules []sca.ScaleRule) tables.Table {
 	return table
 }
 
-func buildEnvVarsTable(container sca.Container) *tables.Table {
+func buildEnvVarsTable(container *sca.Container) *tables.Table {
 	if len(container.EnvironmentVariables) == 0 {
 		return nil
 	}

internal/cmd/alpha/sca/application/generate-payload/generate_payload_test.go

@@ -1,13 +1,9 @@
 package generatepayload
 
 import (
-	"context"
 	"testing"
 
-	"github.com/google/go-cmp/cmp"
-	"github.com/google/go-cmp/cmp/cmpopts"
 	"github.com/google/uuid"
-	sca "github.com/stackitcloud/stackit-sdk-go/services/sca/v1alphaapi"
 
 	"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/testutils"
@@ -17,9 +13,6 @@ const (
 	testRegion = "eu01"
 )
 
-var testClient = &sca.APIClient{DefaultAPI: &sca.DefaultAPIService{}}
-var testCtx = context.Background()
-
 var (
 	testProjectID     = uuid.NewString()
 	testEnvironmentID = uuid.NewString()
@@ -59,14 +52,6 @@ func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
 	return model
 }
 
-func fixtureRequest(mods ...func(request *sca.ApiGetApplicationRequest)) sca.ApiGetApplicationRequest {
-	request := testClient.DefaultAPI.GetApplication(testCtx, testProjectID, testEnvironmentID, testApplicationID)
-	for _, mod := range mods {
-		mod(&request)
-	}
-	return request
-}
-
 func TestParseInput(t *testing.T) {
 	tests := []struct {
 		desc          string
@@ -140,31 +125,3 @@ func TestParseInput(t *testing.T) {
 		})
 	}
 }
-
-func TestBuildRequest(t *testing.T) {
-	tests := []struct {
-		description     string
-		model           *inputModel
-		expectedRequest sca.ApiGetApplicationRequest
-	}{
-		{
-			description:     "base",
-			model:           fixtureInputModel(),
-			expectedRequest: fixtureRequest(),
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.description, func(t *testing.T) {
-			request := buildRequest(testCtx, tt.model, testClient)
-
-			diff := cmp.Diff(request, tt.expectedRequest,
-				cmp.AllowUnexported(tt.expectedRequest),
-				cmpopts.EquateComparable(testCtx, sca.DefaultAPIService{}),
-			)
-			if diff != "" {
-				t.Fatalf("Data does not match: %s", diff)
-			}
-		})
-	}
-}

internal/cmd/alpha/sca/application/update/update.go

@@ -89,7 +89,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
 				`Update the container image of a SCA application with ID "xxx" from an environment with ID "yyy"`,
 				"$ stackit alpha sca application update xxx --image new-image --environment-id yyy"),
 		),
-		PreRunE: func(cmd *cobra.Command, args []string) error {
+		PreRunE: func(cmd *cobra.Command, _ []string) error {
 			updateFlags := []string{
 				imageFlag,
 				publicFlag,
@@ -153,9 +153,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
 				}
 			}
 
-			outputResult(params.Printer, model, resp)
-
-			return nil
+			return outputResult(params.Printer, model, resp)
 		},
 	}
 
@@ -213,7 +211,6 @@ func containersFromInput(containers []sca.Container, model *inputModel) []sca.Co
 				Value:  val,
 			})
 		}
-
 	}
 
 	if updateContainer {