Skip to content

Commit 1d8a65f

Browse files
committed
changes per code review, fix failing test
1 parent d3e6387 commit 1d8a65f

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

cmdstanpy/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -609,7 +609,7 @@ def scan_optimize_csv(path: str, save_iters: bool = False) -> Dict[str, Any]:
609609
if save_iters:
610610
all_iters[i, :] = [float(x) for x in xs]
611611
if i == iters - 1:
612-
mle = np.array([float(x) for x in xs])
612+
mle = np.array(xs, dtype=float)
613613
dict['mle'] = mle
614614
if save_iters:
615615
dict['all_iters'] = all_iters

test/test_optimize.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,9 @@ def test_instantiate(self):
5555
self.assertAlmostEqual(mle.optimized_params_dict['y'], 1, places=3)
5656

5757
def test_instantiate_from_csvfiles(self):
58-
csvfiles_path = os.path.join(DATAFILES_PATH, 'optimize')
58+
csvfiles_path = os.path.join(
59+
DATAFILES_PATH, 'optimize', 'rosenbrock_mle.csv'
60+
)
5961
mle = from_csv(path=csvfiles_path)
6062
self.assertIn('CmdStanMLE: model=rosenbrock', mle.__repr__())
6163
self.assertIn('method=optimize', mle.__repr__())

0 commit comments

Comments
 (0)