Skip to content

Commit 5a1b9c6

Browse files
committed
fix unit tests, cleanup debug stmts
1 parent a891e57 commit 5a1b9c6

2 files changed

Lines changed: 4 additions & 8 deletions

File tree

cmdstanpy/model.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -917,7 +917,6 @@ def sample(
917917
):
918918
assert isinstance(self.exe_file, str) # make typechecker happy
919919
info_dict = model_info(self.exe_file)
920-
get_logger().debug('info_dict\n %s', info_dict)
921920
if (
922921
info_dict is not None
923922
and info_dict['STAN_THREADS'] == 'true'
@@ -935,10 +934,6 @@ def sample(
935934
'Run "install_cmdstan" to upgrade to latest version.',
936935
chains,
937936
)
938-
get_logger().debug(
939-
'one_process_per_chain? %d', one_process_per_chain
940-
)
941-
942937
os.environ['STAN_NUM_THREADS'] = str(num_threads)
943938

944939
# progress reporting
@@ -1372,7 +1367,7 @@ def _run_cmdstan(
13721367
total=iter_total,
13731368
)
13741369
cmd = runset.cmd(idx)
1375-
get_logger().debug(cmd)
1370+
get_logger().debug('CmdStan args: %s', cmd)
13761371

13771372
if not show_progress:
13781373
get_logger().info('%s start processing', logger_prefix)

test/test_sample.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -456,14 +456,15 @@ def test_multi_proc_threads(self):
456456
logging.getLogger()
457457
logistic_model.sample(
458458
data=logistic_data,
459-
chains=7,
459+
chains=4,
460+
parallel_chains=4,
460461
threads_per_chain=5,
461462
iter_sampling=200,
462463
iter_warmup=200,
463464
show_progress=False,
464465
)
465466
log.check_present(
466-
('cmdstanpy', 'DEBUG', 'running CmdStan, num_threads: 35')
467+
('cmdstanpy', 'DEBUG', 'running CmdStan, num_threads: 20')
467468
)
468469

469470
def test_multi_proc_err_msgs(self):

0 commit comments

Comments
 (0)