Update deprecated syntax in tests

Author: WardBrian

test/data/bernoulli with space in name.stan

@@ -1,12 +1,13 @@
 data {
   int<lower=0> N;
-  int<lower=0,upper=1> y[N];
+  array[N] int<lower=0, upper=1> y;
 }
 parameters {
-  real<lower=0,upper=1> theta;
+  real<lower=0, upper=1> theta;
 }
 model {
-  theta ~ beta(1,1);
-  for (n in 1:N)
+  theta ~ beta(1, 1);
+  for (n in 1 : N) 
     y[n] ~ bernoulli(theta);
 }
+

test/data/path with space/bernoulli_path_with_space.stan

@@ -1,12 +1,13 @@
 data {
   int<lower=0> N;
-  int<lower=0,upper=1> y[N];
+  array[N] int<lower=0, upper=1> y;
 }
 parameters {
-  real<lower=0,upper=1> theta;
+  real<lower=0, upper=1> theta;
 }
 model {
-  theta ~ beta(1,1);
-  for (n in 1:N)
+  theta ~ beta(1, 1);
+  for (n in 1 : N) 
     y[n] ~ bernoulli(theta);
 }
+

test/data/path~with~tilde/bernoulli_path_with_tilde.stan

@@ -1,12 +1,13 @@
 data {
   int<lower=0> N;
-  int<lower=0,upper=1> y[N];
+  array[N] int<lower=0, upper=1> y;
 }
 parameters {
-  real<lower=0,upper=1> theta;
+  real<lower=0, upper=1> theta;
 }
 model {
-  theta ~ beta(1,1);
-  for (n in 1:N)
+  theta ~ beta(1, 1);
+  for (n in 1 : N) 
     y[n] ~ bernoulli(theta);
 }
+

test/data/timeout.stan

@@ -1,21 +1,19 @@
 data {
-    // Indicator for endless looping.
-    int loop;
+  // Indicator for endless looping.
+  int loop;
 }
-
 transformed data {
-    // Maybe loop forever so the model times out.
-    real y = 1;
-    while(loop && y) {
-        y += 1;
-    }
+  // Maybe loop forever so the model times out.
+  real y = 1;
+  while (loop && (y != 0.0)) {
+    y += 1;
+  }
 }
-
 parameters {
-    real x;
+  real x;
 }
-
 model {
-    // A nice model so we can get a fit for the `generated_quantities` call.
-    x ~ normal(0, 1);
+  // A nice model so we can get a fit for the `generated_quantities` call.
+  x ~ normal(0, 1);
 }
+

test/test_model.py

@@ -514,19 +514,11 @@ def test_model_format_deprecations() -> None:
 
     sys_stdout = io.StringIO()
     with contextlib.redirect_stdout(sys_stdout):
-        model.format()
+        model.format(canonicalize=True)
 
     formatted = sys_stdout.getvalue()
     assert "//" in formatted
     assert "#" not in formatted
-    assert formatted.count('(') == 5
-
-    sys_stdout = io.StringIO()
-    with contextlib.redirect_stdout(sys_stdout):
-        model.format(canonicalize=True)
-
-    formatted = sys_stdout.getvalue()
-    print(formatted)
     assert "<-" not in formatted
     assert formatted.count('(') == 0