From e825d7446f77961508d953d7e9a3e0e9e450d8f7 Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 16 Sep 2026 09:16:33 +0000 Subject: [PATCH] test: migrate `stats/base/dists/halfnormal/mean` to ULP-based assertions Replaces the computed EPS-based tolerance check with a ULP-based comparison via `isAlmostSameValue`, tightened to the minimum ULP distance (0) that passes across the full fixture set. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Sonnet 5 Claude-Session: https://claude.ai/code/session_01Wskwga4jToojqTe7wRCnNR --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../stats/base/dists/halfnormal/mean/test/test.js | 15 ++++----------- .../dists/halfnormal/mean/test/test.native.js | 15 ++++----------- 2 files changed, 8 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/halfnormal/mean/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/halfnormal/mean/test/test.js index fd0dc03d50bf..8267e6d86ab3 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/halfnormal/mean/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/halfnormal/mean/test/test.js @@ -21,10 +21,9 @@ // MODULES // var tape = require( 'tape' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var mean = require( './../lib' ); @@ -64,24 +63,18 @@ tape( 'if provided a nonpositive `sigma`, the function returns `NaN`', function tape( 'the function returns the expected value of a half-normal distribution', function test( t ) { var expected; - var delta; var sigma; - var tol; + var ULP; var y; var i; sigma = data.sigma; expected = data.expected; + ULP = 0; for ( i = 0; i < sigma.length; i++ ) { y = mean( sigma[i] ); - delta = abs( y - expected[i] ); - tol = 1.0 * EPS * abs( expected[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'sigma: '+sigma[i] ); - } else { - t.ok( delta <= tol, 'within tolerance. σ: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], ULP ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/halfnormal/mean/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/halfnormal/mean/test/test.native.js index 18f943c5158f..3a0cc67a9385 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/halfnormal/mean/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/halfnormal/mean/test/test.native.js @@ -23,9 +23,8 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var tryRequire = require( '@stdlib/utils/try-require' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -69,24 +68,18 @@ tape( 'if provided a nonpositive `sigma`, the function returns `NaN`', opts, fun tape( 'the function returns the expected value of a half-normal distribution', opts, function test( t ) { var expected; - var delta; var sigma; - var tol; + var ULP; var y; var i; expected = data.expected; sigma = data.sigma; + ULP = 0; for ( i = 0; i < sigma.length; i++ ) { y = mean( sigma[i] ); - delta = abs( y - expected[i] ); - tol = 1.0 * EPS * abs( expected[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'sigma: '+sigma[i] ); - } else { - t.ok( delta <= tol, 'within tolerance. σ: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], ULP ), true, 'returns expected value' ); } t.end(); });