From 93854b237789fc6c40673fccb2a41091dc3becb3 Mon Sep 17 00:00:00 2001 From: Mara Averick Date: Mon, 9 Nov 2026 06:02:51 -0700 Subject: [PATCH] bench: fix Boost function call in `math/base/special/gamma1pm1` The Boost benchmark calls `boost::math::gamma1pm1`, which Boost has never defined, so it has never compiled. Boost names the function `tgamma1pm1`, following C's `tgamma`, where stdlib uses `gamma1pm1`. Assisted-by: Claude Opus 5.5 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../base/special/gamma1pm1/benchmark/cpp/boost/benchmark.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/math/base/special/gamma1pm1/benchmark/cpp/boost/benchmark.cpp b/lib/node_modules/@stdlib/math/base/special/gamma1pm1/benchmark/cpp/boost/benchmark.cpp index d0ae8335e840..09761a63b3b6 100644 --- a/lib/node_modules/@stdlib/math/base/special/gamma1pm1/benchmark/cpp/boost/benchmark.cpp +++ b/lib/node_modules/@stdlib/math/base/special/gamma1pm1/benchmark/cpp/boost/benchmark.cpp @@ -100,7 +100,7 @@ double benchmark() { t = tic(); for ( i = 0; i < ITERATIONS; i++ ) { x = randu( rng ); - y = boost::math::gamma1pm1( x ); + y = boost::math::tgamma1pm1( x ); if ( y != y ) { printf( "should not return NaN\n" ); break;