diff --git a/tests/Rules/NewOverSettersRule/Fixture/SkipSetterInLoop.php b/tests/Rules/NewOverSettersRule/Fixture/SkipSetterInLoop.php new file mode 100644 index 00000000..114d3c9a --- /dev/null +++ b/tests/Rules/NewOverSettersRule/Fixture/SkipSetterInLoop.php @@ -0,0 +1,32 @@ +setName($name); + foreach ($items as $item) { + echo $item; + } + } + } + + public function second(array $items) + { + $alwaysSetters = new SomeObject(); + foreach (['Jane', 'Roe'] as $name) { + $alwaysSetters->setName($name); + foreach ($items as $item) { + echo $item; + } + } + } +} diff --git a/tests/Rules/NewOverSettersRule/NewOverSettersRuleTest.php b/tests/Rules/NewOverSettersRule/NewOverSettersRuleTest.php index 94b3c91e..1c22f8f7 100644 --- a/tests/Rules/NewOverSettersRule/NewOverSettersRuleTest.php +++ b/tests/Rules/NewOverSettersRule/NewOverSettersRuleTest.php @@ -47,6 +47,7 @@ public static function provideData(): Iterator yield [__DIR__ . '/Fixture/SkipOnceThanTwiceMethod.php', []]; yield [__DIR__ . '/Fixture/SkipReturnInMiddle.php', []]; yield [__DIR__ . '/Fixture/SkipCalledOnlyOnce.php', []]; + yield [__DIR__ . '/Fixture/SkipSetterInLoop.php', []]; yield [__DIR__ . '/Fixture/SkipSomeKernel.php', []]; yield [__DIR__ . '/Fixture/SkipController.php', []];