From 7a4255f2a70bfb7721a0dd617d8446562cbbc544 Mon Sep 17 00:00:00 2001
From: Tomas Votruba <tomas.vot@gmail.com>
Date: Thu, 24 Sep 2026 00:01:06 +0200
Subject: [PATCH] [ctor] add regression test for setter in loop in
 NewOverSettersRule

---
 .../Fixture/SkipSetterInLoop.php              | 32 +++++++++++++++++++
 .../NewOverSettersRuleTest.php                |  1 +
 2 files changed, 33 insertions(+)
 create mode 100644 tests/Rules/NewOverSettersRule/Fixture/SkipSetterInLoop.php

diff --git a/tests/Rules/NewOverSettersRule/Fixture/SkipSetterInLoop.php b/tests/Rules/NewOverSettersRule/Fixture/SkipSetterInLoop.php
new file mode 100644
index 00000000..114d3c9a
--- /dev/null
+++ b/tests/Rules/NewOverSettersRule/Fixture/SkipSetterInLoop.php
@@ -0,0 +1,32 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\NewOverSettersRule\Fixture;
+
+use Symplify\PHPStanRules\Tests\Rules\NewOverSettersRule\Source\SomeObject;
+
+final class SkipSetterInLoop
+{
+    public function first(array $items)
+    {
+        $alwaysSetters = new SomeObject();
+        foreach (['John', 'Doe'] as $name) {
+            $alwaysSetters->setName($name);
+            foreach ($items as $item) {
+                echo $item;
+            }
+        }
+    }
+
+    public function second(array $items)
+    {
+        $alwaysSetters = new SomeObject();
+        foreach (['Jane', 'Roe'] as $name) {
+            $alwaysSetters->setName($name);
+            foreach ($items as $item) {
+                echo $item;
+            }
+        }
+    }
+}
diff --git a/tests/Rules/NewOverSettersRule/NewOverSettersRuleTest.php b/tests/Rules/NewOverSettersRule/NewOverSettersRuleTest.php
index 94b3c91e..1c22f8f7 100644
--- a/tests/Rules/NewOverSettersRule/NewOverSettersRuleTest.php
+++ b/tests/Rules/NewOverSettersRule/NewOverSettersRuleTest.php
@@ -47,6 +47,7 @@ public static function provideData(): Iterator
         yield [__DIR__ . '/Fixture/SkipOnceThanTwiceMethod.php', []];
         yield [__DIR__ . '/Fixture/SkipReturnInMiddle.php', []];
         yield [__DIR__ . '/Fixture/SkipCalledOnlyOnce.php', []];
+        yield [__DIR__ . '/Fixture/SkipSetterInLoop.php', []];
 
         yield [__DIR__ . '/Fixture/SkipSomeKernel.php', []];
         yield [__DIR__ . '/Fixture/SkipController.php', []];