From d3d42b34830e37a2c87639d39bfff5cd7a7b426a Mon Sep 17 00:00:00 2001 From: Byungjin Park Date: Sun, 20 Sep 2026 00:53:33 +0900 Subject: [PATCH] fix(actions): run the failure summary steps after a failed step - Add `always()` to every `if: steps..outcome == 'failure'` in the composite check actions. Without a status function the runner adds an implicit `success()`, so the summary step was skipped exactly when it was needed; runner logs show it ending with `outcome=skipped` after a failing check --- .github/actions/github-actions.actionlint/action.yaml | 2 +- .github/actions/github-actions.check-jsonschema/action.yaml | 2 +- .github/actions/terraform.docs/action.yaml | 2 +- .github/actions/terraform.fmt/action.yaml | 2 +- .github/actions/terraform.tflint/action.yaml | 4 ++-- .github/actions/terraform.validate/action.yaml | 4 ++-- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/actions/github-actions.actionlint/action.yaml b/.github/actions/github-actions.actionlint/action.yaml index 2687e50..e468ce0 100644 --- a/.github/actions/github-actions.actionlint/action.yaml +++ b/.github/actions/github-actions.actionlint/action.yaml @@ -65,7 +65,7 @@ runs: - name: Add Failure Details to Job Summary id: actionlint-summary - if: steps.actionlint.outcome == 'failure' + if: always() && steps.actionlint.outcome == 'failure' uses: tedilabs/github-actions/.github/actions/github.step-summary@main with: title: "❌ actionlint · ${{ inputs.target_dir }}" diff --git a/.github/actions/github-actions.check-jsonschema/action.yaml b/.github/actions/github-actions.check-jsonschema/action.yaml index b72f445..dca0102 100644 --- a/.github/actions/github-actions.check-jsonschema/action.yaml +++ b/.github/actions/github-actions.check-jsonschema/action.yaml @@ -92,7 +92,7 @@ runs: - name: Add Failure Details to Job Summary id: validate-summary - if: steps.validate.outcome == 'failure' + if: always() && steps.validate.outcome == 'failure' uses: tedilabs/github-actions/.github/actions/github.step-summary@main with: title: "❌ check-jsonschema (${{ inputs.schema_type }}) · ${{ steps.target.outputs.target_dir }}" diff --git a/.github/actions/terraform.docs/action.yaml b/.github/actions/terraform.docs/action.yaml index 7b37a4f..e7b9096 100644 --- a/.github/actions/terraform.docs/action.yaml +++ b/.github/actions/terraform.docs/action.yaml @@ -138,7 +138,7 @@ runs: - name: Add Failure Details to Job Summary id: docs-summary - if: steps.docs.outcome == 'failure' + if: always() && steps.docs.outcome == 'failure' uses: tedilabs/github-actions/.github/actions/github.step-summary@main with: title: "❌ terraform-docs · ${{ inputs.target_dir }}" diff --git a/.github/actions/terraform.fmt/action.yaml b/.github/actions/terraform.fmt/action.yaml index dd26ae9..af686a4 100644 --- a/.github/actions/terraform.fmt/action.yaml +++ b/.github/actions/terraform.fmt/action.yaml @@ -68,7 +68,7 @@ runs: - name: Add Failure Details to Job Summary id: fmt-summary - if: steps.fmt.outcome == 'failure' + if: always() && steps.fmt.outcome == 'failure' uses: tedilabs/github-actions/.github/actions/github.step-summary@main with: title: "❌ terraform fmt · ${{ inputs.target_dir }}" diff --git a/.github/actions/terraform.tflint/action.yaml b/.github/actions/terraform.tflint/action.yaml index 556f0b1..0af0c01 100644 --- a/.github/actions/terraform.tflint/action.yaml +++ b/.github/actions/terraform.tflint/action.yaml @@ -115,7 +115,7 @@ runs: - name: Add Failure Details to Job Summary id: init-summary - if: steps.init.outcome == 'failure' + if: always() && steps.init.outcome == 'failure' uses: tedilabs/github-actions/.github/actions/github.step-summary@main with: title: "❌ tflint --init · ${{ inputs.target_dir }}" @@ -148,7 +148,7 @@ runs: - name: Add Failure Details to Job Summary id: tflint-summary - if: steps.tflint.outcome == 'failure' + if: always() && steps.tflint.outcome == 'failure' uses: tedilabs/github-actions/.github/actions/github.step-summary@main with: title: "❌ tflint · ${{ inputs.target_dir }}" diff --git a/.github/actions/terraform.validate/action.yaml b/.github/actions/terraform.validate/action.yaml index 5c27802..e8f28c6 100644 --- a/.github/actions/terraform.validate/action.yaml +++ b/.github/actions/terraform.validate/action.yaml @@ -67,7 +67,7 @@ runs: - name: Add Failure Details to Job Summary id: init-summary - if: steps.init.outcome == 'failure' + if: always() && steps.init.outcome == 'failure' uses: tedilabs/github-actions/.github/actions/github.step-summary@main with: title: "❌ terraform init · ${{ inputs.target_dir }}${{ inputs.workspace && format(' ({0})', inputs.workspace) || '' }}" @@ -91,7 +91,7 @@ runs: - name: Add Failure Details to Job Summary id: validate-summary - if: steps.validate.outcome == 'failure' + if: always() && steps.validate.outcome == 'failure' uses: tedilabs/github-actions/.github/actions/github.step-summary@main with: title: "❌ terraform validate · ${{ inputs.target_dir }}${{ inputs.workspace && format(' ({0})', inputs.workspace) || '' }}"