matchers: extra message two empty maps shouldNot equal (#1560)

Author: MykolaGolubyev

webtau-core/src/main/java/org/testingisdocumenting/webtau/expectation/equality/handlers/MapsCompareToHandler.java

@@ -26,6 +26,8 @@
 import java.util.Map;
 import java.util.Set;
 
+import static org.testingisdocumenting.webtau.WebTauCore.*;
+
 public class MapsCompareToHandler implements CompareToHandler {
     @Override
     public boolean handleEquality(Object actual, Object expected) {
@@ -64,6 +66,13 @@ private class Comparator {
         }
 
         void compare() {
+            if (compareToComparator.getAssertionMode() == CompareToComparator.AssertionMode.NOT_EQUAL) {
+                if (actualMap.isEmpty() && expectedMap.isEmpty()) {
+                    compareToComparator.reportEqual(MapsCompareToHandler.this, actualPath,
+                            tokenizedMessage().error("both maps are empty"));
+                }
+            }
+
             allKeys.forEach(this::handleKey);
         }
 

webtau-core/src/test/groovy/org/testingisdocumenting/webtau/expectation/equality/handlers/MapsCompareToHandlerTest.groovy

@@ -76,4 +76,13 @@ class MapsCompareToHandlerTest {
             actual([[k1: 'v1']], 'map').shouldNot(equal([k1: 'v1']))
         }
     }
+
+    @Test
+    void "empty map should not equal empty map"() {
+        runExpectExceptionAndValidateOutput(AssertionError.class, 'X failed expecting [value] to not equal {}: both maps are empty (Xms)\n' +
+                '  \n' +
+                '  {}') {
+            actual([:]).shouldNot(equal([:]))
+        }
+    }
 }

webtau-core/src/test/java/org/testingisdocumenting/webtau/expectation/equality/SnapshotAwareDummyValue.java

@@ -18,15 +18,13 @@
 
 import org.testingisdocumenting.webtau.data.snapshot.SnapshotValueAware;
 
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
 
 import static org.testingisdocumenting.webtau.WebTauCore.*;
 
 public class SnapshotAwareDummyValue implements SnapshotValueAware {
     private Object snapshot;
-    private final List<Map<String, Object>> data;
+    private List<Map<String, Object>> data;
     private boolean incrementValueIdx;
     private int currentValueIdx; // for wait testing
 
@@ -42,6 +40,11 @@ public void doOperation() {
         data.set(0, map("id", "tid1", "name", "name1-changed"));
     }
 
+    public void makeEmpty() {
+        data = new ArrayList<>();
+        data.add(new HashMap<>());
+    }
+
     public void enableAutoIncrement() {
        incrementValueIdx = true;
     }

webtau-core/src/test/java/org/testingisdocumenting/webtau/expectation/equality/SnapshotChangeValueMatcherJavaTest.java

@@ -37,6 +37,18 @@ public void change() {
         });
     }
 
+    @Test
+    public void changeEmptyMap() {
+        var value = new SnapshotAwareDummyValue();
+        value.makeEmpty();
+        value.takeSnapshot();
+
+        TestConsoleOutput.runExpectExceptionAndValidateOutput(AssertionError.class, """
+                X failed expecting [value] to change: both maps are empty (Xms)""", () -> {
+            actual(value).should(change);
+        });
+    }
+
     @Test
     public void waitChange() {
         var value = new SnapshotAwareDummyValue();

webtau-docs/znai/release-notes/2.4/add-2024-01-05-empty-map-message.md

@@ -0,0 +1 @@
+* Add: Extra message in case of two empty maps and `shouldNot` `equal`