make filtering safer

Author: cevian

nbs/00_vector.ipynb

@@ -241,6 +241,9 @@
     "            .format(index_name=self._get_embedding_index_name(), table_name=self._quote_ident(self.table_name), column_name=self._quote_ident(column_name), index_method=index_method, num_lists=num_lists)\n",
     "\n",
     "    def _where_clause_for_filter(self, params: List, filter: Optional[Union[Dict[str, str], List[Dict[str, str]]]]) -> Tuple[str, List]:\n",
+    "        if filter == None:\n",
+    "            return (\"TRUE\", params)\n",
+    "\n",
     "        if isinstance(filter, dict):\n",
     "            where = \"metadata @> ${index}\".format(index=len(params)+1)\n",
     "            json_object = json.dumps(filter)\n",
@@ -253,7 +256,7 @@
     "                index=len(params) + 1)\n",
     "            params = params + [any_params]\n",
     "        else:\n",
-    "            where = \"TRUE\"\n",
+    "            raise ValueError(\"Unknown filter type: {filter_type}\".format(filter_type=type(filter)))\n",
     "\n",
     "        return (where, params)\n",
     "\n",

timescale_vector/client.py

@@ -166,6 +166,9 @@ def create_ivfflat_index_query(self, num_records):
             .format(index_name=self._get_embedding_index_name(), table_name=self._quote_ident(self.table_name), column_name=self._quote_ident(column_name), index_method=index_method, num_lists=num_lists)
 
     def _where_clause_for_filter(self, params: List, filter: Optional[Union[Dict[str, str], List[Dict[str, str]]]]) -> Tuple[str, List]:
+        if filter == None:
+            return ("TRUE", params)
+
         if isinstance(filter, dict):
             where = "metadata @> ${index}".format(index=len(params)+1)
             json_object = json.dumps(filter)
@@ -178,7 +181,7 @@ def _where_clause_for_filter(self, params: List, filter: Optional[Union[Dict[str
                 index=len(params) + 1)
             params = params + [any_params]
         else:
-            where = "TRUE"
+            raise ValueError("Unknown filter type: {filter_type}".format(filter_type=type(filter)))
 
         return (where, params)