Skip to content

Commit 91cc7ed

Browse files
ceviancevian
committed
Change delete_by_id to delete_by_ids and take multiple ids
1 parent 9bacf7f commit 91cc7ed

5 files changed

Lines changed: 22 additions & 22 deletions

File tree

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ records[0][client.SEARCH_RESULT_DISTANCE_IDX]
143143
You can delete by ID:
144144

145145
``` python
146-
await vec.delete_by_id(records[0][client.SEARCH_RESULT_ID_IDX])
146+
await vec.delete_by_ids([records[0][client.SEARCH_RESULT_ID_IDX]])
147147
```
148148

149149
[]

‎nbs/00_vector.ipynb‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,8 @@
187187
" def delete_all_query(self):\n",
188188
" return \"TRUNCATE {table_name};\".format(table_name=self._quote_ident(self.table_name))\n",
189189
"\n",
190-
" def delete_by_id_query(self, id: uuid.UUID) -> Tuple[str, List]:\n",
191-
" query = \"DELETE FROM {table_name} WHERE id = $1;\".format(table_name=self._quote_ident(self.table_name))\n",
190+
" def delete_by_ids_query(self, id: List[uuid.UUID]) -> Tuple[str, List]:\n",
191+
" query = \"DELETE FROM {table_name} WHERE id = ANY($1);\".format(table_name=self._quote_ident(self.table_name))\n",
192192
" return (query, [id])\n",
193193
"\n",
194194
" def delete_by_metadata_query (self, filter: Union[Dict[str, str], List[Dict[str, str]]]) -> Tuple[str, List]:\n",
@@ -436,11 +436,11 @@
436436
" async with await self.connect() as pool:\n",
437437
" await pool.execute(query)\n",
438438
"\n",
439-
" async def delete_by_id(self, id: uuid.UUID):\n",
439+
" async def delete_by_ids(self, id: List[uuid.UUID]):\n",
440440
" \"\"\"\n",
441441
" Delete records by id.\n",
442442
" \"\"\"\n",
443-
" (query, params) = self.builder.delete_by_id_query(id)\n",
443+
" (query, params) = self.builder.delete_by_ids_query(id)\n",
444444
" async with await self.connect() as pool:\n",
445445
" return await pool.fetch(query, *params)\n",
446446
"\n",
@@ -756,7 +756,7 @@
756756
"\n",
757757
"rec = await vec.search([1.0, 2.0], k=4, filter=[{\"key_1\":\"val_1\"}, {\"key2\":\"val2\"}])\n",
758758
"assert len(rec) == 2\n",
759-
"await vec.delete_by_id(rec[0][SEARCH_RESULT_ID_IDX])\n",
759+
"await vec.delete_by_ids([rec[0][SEARCH_RESULT_ID_IDX]])\n",
760760
"rec = await vec.search([1.0, 2.0], k=4, filter=[{\"key_1\":\"val_1\"}, {\"key2\":\"val2\"}])\n",
761761
"assert len(rec) == 1\n",
762762
"await vec.delete_by_metadata([{\"key_1\":\"val_1\"}, {\"key2\":\"val2\"}])\n",
@@ -935,11 +935,11 @@
935935
" with conn.cursor() as cur:\n",
936936
" cur.execute(query)\n",
937937
" \n",
938-
" def delete_by_id(self, id: uuid.UUID):\n",
938+
" def delete_by_ids(self, id: List[uuid.UUID]):\n",
939939
" \"\"\"\n",
940940
" Delete records by id.\n",
941941
" \"\"\"\n",
942-
" (query, params) = self.builder.delete_by_id_query(id)\n",
942+
" (query, params) = self.builder.delete_by_ids_query(id)\n",
943943
" query, params = self._translate_to_pyformat(query, params)\n",
944944
" with self.connect() as conn:\n",
945945
" with conn.cursor() as cur:\n",
@@ -1291,7 +1291,7 @@
12911291
"\n",
12921292
"rec = vec.search([1.0, 2.0], k=4, filter=[{\"key_1\":\"val_1\"}, {\"key2\":\"val2\"}])\n",
12931293
"len(rec) == 2\n",
1294-
"vec.delete_by_id(rec[0][SEARCH_RESULT_ID_IDX])\n",
1294+
"vec.delete_by_ids([rec[0][SEARCH_RESULT_ID_IDX]])\n",
12951295
"rec = vec.search([1.0, 2.0], k=4, filter=[{\"key_1\":\"val_1\"}, {\"key2\":\"val2\"}])\n",
12961296
"assert len(rec) == 1\n",
12971297
"vec.delete_by_metadata([{\"key_1\":\"val_1\"}, {\"key2\":\"val2\"}])\n",

‎nbs/index.ipynb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@
429429
}
430430
],
431431
"source": [
432-
"await vec.delete_by_id(records[0][client.SEARCH_RESULT_ID_IDX])"
432+
"await vec.delete_by_ids([records[0][client.SEARCH_RESULT_ID_IDX]])"
433433
]
434434
},
435435
{

‎timescale_vector/_modidx.py‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
'timescale_vector/client.py'),
2121
'timescale_vector.client.Async.delete_all': ( 'vector.html#async.delete_all',
2222
'timescale_vector/client.py'),
23-
'timescale_vector.client.Async.delete_by_id': ( 'vector.html#async.delete_by_id',
24-
'timescale_vector/client.py'),
23+
'timescale_vector.client.Async.delete_by_ids': ( 'vector.html#async.delete_by_ids',
24+
'timescale_vector/client.py'),
2525
'timescale_vector.client.Async.delete_by_metadata': ( 'vector.html#async.delete_by_metadata',
2626
'timescale_vector/client.py'),
2727
'timescale_vector.client.Async.drop_embedding_index': ( 'vector.html#async.drop_embedding_index',
@@ -45,8 +45,8 @@
4545
'timescale_vector/client.py'),
4646
'timescale_vector.client.QueryBuilder.delete_all_query': ( 'vector.html#querybuilder.delete_all_query',
4747
'timescale_vector/client.py'),
48-
'timescale_vector.client.QueryBuilder.delete_by_id_query': ( 'vector.html#querybuilder.delete_by_id_query',
49-
'timescale_vector/client.py'),
48+
'timescale_vector.client.QueryBuilder.delete_by_ids_query': ( 'vector.html#querybuilder.delete_by_ids_query',
49+
'timescale_vector/client.py'),
5050
'timescale_vector.client.QueryBuilder.delete_by_metadata_query': ( 'vector.html#querybuilder.delete_by_metadata_query',
5151
'timescale_vector/client.py'),
5252
'timescale_vector.client.QueryBuilder.drop_embedding_index_query': ( 'vector.html#querybuilder.drop_embedding_index_query',
@@ -79,8 +79,8 @@
7979
'timescale_vector/client.py'),
8080
'timescale_vector.client.Sync.delete_all': ( 'vector.html#sync.delete_all',
8181
'timescale_vector/client.py'),
82-
'timescale_vector.client.Sync.delete_by_id': ( 'vector.html#sync.delete_by_id',
83-
'timescale_vector/client.py'),
82+
'timescale_vector.client.Sync.delete_by_ids': ( 'vector.html#sync.delete_by_ids',
83+
'timescale_vector/client.py'),
8484
'timescale_vector.client.Sync.delete_by_metadata': ( 'vector.html#sync.delete_by_metadata',
8585
'timescale_vector/client.py'),
8686
'timescale_vector.client.Sync.drop_embedding_index': ( 'vector.html#sync.drop_embedding_index',

‎timescale_vector/client.py‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,8 @@ def drop_embedding_index_query(self):
112112
def delete_all_query(self):
113113
return "TRUNCATE {table_name};".format(table_name=self._quote_ident(self.table_name))
114114

115-
def delete_by_id_query(self, id: uuid.UUID) -> Tuple[str, List]:
116-
query = "DELETE FROM {table_name} WHERE id = $1;".format(table_name=self._quote_ident(self.table_name))
115+
def delete_by_ids_query(self, id: List[uuid.UUID]) -> Tuple[str, List]:
116+
query = "DELETE FROM {table_name} WHERE id = ANY($1);".format(table_name=self._quote_ident(self.table_name))
117117
return (query, [id])
118118

119119
def delete_by_metadata_query (self, filter: Union[Dict[str, str], List[Dict[str, str]]]) -> Tuple[str, List]:
@@ -301,11 +301,11 @@ async def delete_all(self, drop_index=True):
301301
async with await self.connect() as pool:
302302
await pool.execute(query)
303303

304-
async def delete_by_id(self, id: uuid.UUID):
304+
async def delete_by_ids(self, id: List[uuid.UUID]):
305305
"""
306306
Delete records by id.
307307
"""
308-
(query, params) = self.builder.delete_by_id_query(id)
308+
(query, params) = self.builder.delete_by_ids_query(id)
309309
async with await self.connect() as pool:
310310
return await pool.fetch(query, *params)
311311

@@ -521,11 +521,11 @@ def delete_all(self, drop_index=True):
521521
with conn.cursor() as cur:
522522
cur.execute(query)
523523

524-
def delete_by_id(self, id: uuid.UUID):
524+
def delete_by_ids(self, id: List[uuid.UUID]):
525525
"""
526526
Delete records by id.
527527
"""
528-
(query, params) = self.builder.delete_by_id_query(id)
528+
(query, params) = self.builder.delete_by_ids_query(id)
529529
query, params = self._translate_to_pyformat(query, params)
530530
with self.connect() as conn:
531531
with conn.cursor() as cur:

0 commit comments

Comments
 (0)