fall back scalers to strings where there isn't a well known alternative

Author: tocsoft

Tocsoft.GraphQLCodeGen.Cli/CodeGeneratorSettingsLoader.cs

@@ -235,7 +235,7 @@ private SimpleSourceFile Load(string path, CodeGeneratorSettingsLoaderDefaults s
 
                 if (string.IsNullOrWhiteSpace(file.Format))
                 {
-                    file.Format = settings.Format;
+                    file.Format = settings.Format ?? "cs";
                 }
             }
 

Tocsoft.GraphQLCodeGen.Cli/TemplateEngine.cs

@@ -80,12 +80,16 @@ public TemplateEngine(IEnumerable<string> templates, IDictionary<string, string>
 
             HandlebarsBlockHelper ifTemplateHelper = (output, options, context, args) =>
             {
-                var val = this.engine.Compile("{{> " + args[0].ToString() + "}}")((object)context)?.ToString()?.Trim();
-                var isSet = !string.IsNullOrWhiteSpace(val);
-
-                if (args.Length > 1)
+                var isSet = false;
+                if (registerTemplates.Contains(args[0].ToString(), StringComparer.OrdinalIgnoreCase)) // need to check if its case insenative
                 {
-                    isSet = val.Equals(args[1]?.ToString());
+                    var val = this.engine.Compile("{{> " + args[0].ToString() + "}}")((object)context)?.ToString()?.Trim();
+                    isSet = !string.IsNullOrWhiteSpace(val);
+
+                    if (args.Length > 1)
+                    {
+                        isSet = val.Equals(args[1]?.ToString());
+                    }
                 }
 
                 if (isSet)
@@ -131,9 +135,15 @@ public TemplateEngine(IEnumerable<string> templates, IDictionary<string, string>
 
             foreach (var a in templateArguments)
             {
-                this.engine.RegisterTemplate(a.Key, a.Value);
+                this.RegisterTemplate(a.Key, a.Value);
             }
         }
+        List<string> registerTemplates = new List<string>();
+        private void RegisterTemplate(string templateName, string template)
+        {
+            registerTemplates.Add(template);
+            this.engine.RegisterTemplate(templateName, template);
+        }
 
 
         private class NullEncoder : ITextEncoder
@@ -205,7 +215,7 @@ private void RegisterTemplate(StringBuilder sb, string currentTemplateName)
             }
             else
             {
-                this.engine.RegisterTemplate(currentTemplateName, sb.ToString().TrimEnd());
+                this.RegisterTemplate(currentTemplateName, sb.ToString().TrimEnd());
             }
             sb.Clear();
         }

Tocsoft.GraphQLCodeGen.Cli/Templates/cs/CSharp.template

@@ -307,7 +307,12 @@ namespace {{Namespace}}
 		{{~/each~}}
 
 {{!# TypeReference}}
-	{{~#if IsScaler}}{{ > (concat 'TypeReference_' TypeName) }}
+	{{~#if IsScaler}}
+	{{~ifTemplate (concat 'TypeReference_' TypeName)~}}
+		{{ > (concat 'TypeReference_' TypeName) }}
+	{{~else~}}
+		{{ > (concat 'TypeReference_String') }}
+	{{~/ifTemplate~}} 
 	{{~else~}}
 	{{~#if IsEnum~}}
 	{{> RenderTypeReference name=TypeName  prefix=true fixCase=true isValueType=true isCollection=IsCollection nullable=CanValueBeNull }}

Tocsoft.GraphQLCodeGen.Tests/FakeLogger.cs

@@ -0,0 +1,41 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using Tocsoft.GraphQLCodeGen.Cli;
+
+namespace Tocsoft.GraphQLCodeGen.Tests
+{
+    public class FakeLogger : ILogger
+    {
+        public bool HasErrors => logs?.Any(c => c.IsError) == true;
+        public bool HasMessages => logs?.Any() == true;
+
+        private List<LogEntry> logs = new List<LogEntry>();
+
+        public IEnumerable<string> ErrorMessages => logs?.Where(x => x.IsError).Select(x => x.Message).ToArray() ?? Array.Empty<string>();
+
+        public void Error(string str)
+        {
+            logs = logs ?? new List<LogEntry>();
+            var msg = new LogEntry(str, true);
+            logs.Add(msg);
+        }
+
+        public void Message(string str)
+        {
+            logs = logs ?? new List<LogEntry>();
+            logs.Add(new LogEntry(str, false));
+        }
+
+        public struct LogEntry
+        {
+            public LogEntry(string message, bool isError)
+            {
+                Message = message;
+                IsError = isError;
+            }
+            public string Message { get; }
+            public bool IsError { get; }
+        }
+    }
+}

Tocsoft.GraphQLCodeGen.Tests/Files/GithubTemplateError/History.gql

@@ -0,0 +1,18 @@
+
+query($repository:String!, $owner:String!, $tag:String!) { 
+  repository(name:$repository, owner:$owner){
+    ref(qualifiedName: $tag){
+      name
+    target{
+      			... on Commit { 
+        	history(first:100){
+            nodes{
+              id,
+              oid,
+              message
+            }
+        	}
+      	}
+    	}  
+    }}
+          }