Skip to content
This repository was archived by the owner on Feb 4, 2023. It is now read-only.

Commit 33936fe

Browse files
committed
[refactoring] replace backtick commands x with $(x)
1 parent bb98533 commit 33936fe

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/universalJavaApplicationStub

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -304,12 +304,12 @@ fi
304304

305305

306306
# helper function:
307-
# extract Java version string from `java -version` command
307+
# extract Java version string from 'java -version' command
308308
# works for both old (1.8) and new (9) version schema
309309
##########################################################
310310
function extractJavaVersionString() {
311311
# second sed command strips " and -ea from the version string
312-
echo `"$1" -version 2>&1 | awk '/version/{print $NF}' | sed -E 's/"//g;s/-ea//g'`
312+
echo $("$1" -version 2>&1 | awk '/version/{print $NF}' | sed -E 's/"//g;s/-ea//g')
313313
}
314314

315315

test/java-version-tester.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@
66

77

88
# helper function:
9-
# extract Java version string from `java -version` command
9+
# extract Java version string from 'java -version' command
1010
# works for both old (1.8) and new (9) version schema
1111
##########################################################
1212
function extractJavaVersionString() {
1313
# second sed command strips " and -ea from the version string
14-
echo `"$1" -version 2>&1 | awk '/version/{print $NF}' | sed -E 's/"//g;s/-ea//g'`
14+
echo $("$1" -version 2>&1 | awk '/version/{print $NF}' | sed -E 's/"//g;s/-ea//g')
1515
}
1616

1717

@@ -96,7 +96,7 @@ function JavaVersionSatisfiesRequirement() {
9696
function testExtractMajor() {
9797
java_version=$1
9898
expected_major=$2
99-
actual_major=`extractJavaMajorVersion $java_version`
99+
actual_major=$(extractJavaMajorVersion "$java_version")
100100
if [ ${expected_major} == ${actual_major} ] ; then
101101
echo "[TEST OK] Extracted Java major version '${actual_major}' for Java '${java_version}'"
102102
else
@@ -226,7 +226,7 @@ function testSatisfies() {
226226
java_version=$1
227227
java_requirement=$2
228228
expected_result=$3
229-
actual_result=`JavaVersionSatisfiesRequirement $java_version $java_requirement ; echo $?`
229+
actual_result=$(JavaVersionSatisfiesRequirement $java_version $java_requirement ; echo $?)
230230
if [ ${expected_result} == ${actual_result} ] ; then
231231
case $expected_result in
232232
0)

0 commit comments

Comments
 (0)