feat/withPackages method in builder to provide where sdk is used

Author: piotr-szewczyk

.idea/workspace.xml

@@ -47,6 +47,11 @@ public class ClientOptions {
      */
     private IHttpAsyncClient httpClient;
 
+    /**
+     * List of packages where SDK is used.
+     */
+    private List<String> packages = new ArrayList<>();
+
     public ClientOptions() {}
 
     public ClientOptions(ClientOptions configuration) {
@@ -57,6 +62,15 @@ public ClientOptions(ClientOptions configuration) {
         this.isCatchUncaughtException = configuration.isCatchUncaughtException();
         this.handlers = configuration.getHandlers();
         this.httpClient = configuration.getHttpClient();
+        this.packages = configuration.getPackages();
+    }
+
+    public List<String> getPackages() {
+        return packages;
+    }
+
+    public void setPackages(List<String> packages) {
+        this.packages = packages;
     }
 
     public void setHandlers(List<IHandler> handlers) {

traceo-sdk-core/src/main/java/com/traceo/sdk/ClientOptions.java

@@ -2,6 +2,8 @@
 
 import com.traceo.sdk.ClientOptions;
 
+import java.util.List;
+
 /**
  * Base class for every client builders.
  *
@@ -77,4 +79,16 @@ public final Subclass withCatchUncaughtException(boolean enabled) {
         configuration.setCatchUncaughtException(enabled);
         return getSubclass();
     }
+
+    /**
+     * List of packages where SDK is used. Based on this values, SDK
+     * can check wheter incoming exception is inside client code or in external library.
+     *
+     * @param packages List of packages where SDK is used.
+     * @return
+     */
+    public final Subclass withPackages(List<String> packages) {
+        configuration.setPackages(packages);
+        return getSubclass();
+    }
 }

traceo-sdk-core/src/main/java/com/traceo/sdk/builder/CoreBuilder.java

@@ -12,6 +12,7 @@
 
 public class IncidentHandler {
     private final static SDKLogger LOGGER = new SDKLogger(IncidentHandler.class);
+    private final static String TRACEO_PACKAGE = "com.traceo.sdk";
 
     private final ClientOptions options;
 
@@ -34,7 +35,7 @@ public void catchException(Throwable throwable, String message, EventCallback<Tr
             return;
         }
 
-        TraceoIncident payload = processIncident(throwable, message);
+        TraceoIncident payload = processIncident(throwable, message, options);
         if (callback != null) {
             callback.run(payload);
         }
@@ -47,7 +48,7 @@ public void catchException(Throwable throwable, String message, EventCallback<Tr
         }
     }
 
-    private static TraceoIncident processIncident(Throwable throwable, String customMessage) {
+    private static TraceoIncident processIncident(Throwable throwable, String customMessage, ClientOptions options) {
         TraceoIncident traceoIncident = new TraceoIncident();
 
         String stacktrace = ThrowableUtils.stacktraceToString(throwable);
@@ -61,7 +62,7 @@ private static TraceoIncident processIncident(Throwable throwable, String custom
             traceoIncident.setMessage(throwable.getMessage());
         }
 
-        List<TraceoTrace> traces = getTraceList(throwable);
+        List<TraceoTrace> traces = getTraceList(throwable, options);
         traceoIncident.setTraces(traces);
 
         traceoIncident.setStack(stacktrace);
@@ -70,21 +71,36 @@ private static TraceoIncident processIncident(Throwable throwable, String custom
         return traceoIncident;
     }
 
-    private static List<TraceoTrace> getTraceList(Throwable throwable) {
+    private static List<TraceoTrace> getTraceList(Throwable throwable, ClientOptions options) {
         List<TraceoTrace> traces = new ArrayList<>();
 
-        for (StackTraceElement stackTraceElement : throwable.getStackTrace()) {
+        for (StackTraceElement element : throwable.getStackTrace()) {
+            if (element == null) {
+                continue;
+            }
+
             TraceoTrace trace = new TraceoTrace();
-            trace.setFunction(stackTraceElement.getMethodName());
 
-            String[] splitFilename = stackTraceElement.getFileName().split("\\.");
+            String className = element.getClassName();
+            if (className.startsWith(TRACEO_PACKAGE)) {
+                continue;
+            }
+
+            String[] splitFilename = element.getFileName().split("\\.");
             if (splitFilename.length > 1) {
                 trace.setExtension(splitFilename[1]);
             }
 
-            trace.setFilename(stackTraceElement.getFileName());
-            trace.setLineNo(stackTraceElement.getLineNumber());
-            trace.setAbsPath(stackTraceElement.getClassName());
+            if (!element.isNativeMethod()) {
+                trace.setLineNo(element.getLineNumber());
+            }
+
+            trace.setFilename(element.getFileName());
+            trace.setFunction(element.getMethodName());
+            trace.setAbsPath(element.getClassName());
+
+            boolean isInternalTrace = options.getPackages().stream().anyMatch(className::startsWith);
+            trace.setInternal(isInternalTrace);
 
             traces.add(trace);
         }