Skip to content

Commit f5b68a7

Browse files
fix/logger and events handler improvements, wrong api endpoint provided
1 parent 58b3a0a commit f5b68a7

7 files changed

Lines changed: 89 additions & 63 deletions

File tree

.idea/workspace.xml

Lines changed: 59 additions & 47 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

traceo-sdk-core/src/main/java/com/traceo/sdk/handlers/IncidentHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public void catchException(Throwable throwable, String message, EventCallback<Tr
4040
}
4141

4242
try {
43-
DefaultRequest<TraceoIncident> request = new DefaultRequest<>("/incident", payload);
43+
DefaultRequest<TraceoIncident> request = new DefaultRequest<>("/api/capture/incident", payload);
4444
options.getHttpClient().execute(request);
4545
} catch (Throwable e) {
4646
LOGGER.error("Failed to send exception.", e);
@@ -79,10 +79,10 @@ private static List<TraceoTrace> getTraceList(Throwable throwable) {
7979

8080
String[] splitFilename = stackTraceElement.getFileName().split("\\.");
8181
if (splitFilename.length > 1) {
82-
trace.setFilename(splitFilename[0]);
8382
trace.setExtension(splitFilename[1]);
8483
}
8584

85+
trace.setFilename(stackTraceElement.getFileName());
8686
trace.setLineNo(stackTraceElement.getLineNumber());
8787
trace.setAbsPath(stackTraceElement.getClassName());
8888

traceo-sdk-core/src/main/java/com/traceo/sdk/http/HttpAsyncClient.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,10 @@ public Future<HttpResponse> execute(IRequest<?> request) {
8989
public void completed(HttpResponse httpResponse) {
9090
int statusCode = httpResponse.getStatusLine().getStatusCode();
9191

92-
if (statusCode != 200) {
93-
LOGGER.error("Failed to send request. Received status code: {}", statusCode);
94-
} else {
92+
if (statusCode >= 200 && statusCode <= 300) {
9593
LOGGER.log("Request has been send successfully.");
94+
} else {
95+
LOGGER.error("Failed to send request. Received status code: {}", statusCode);
9696
}
9797

9898
latch.countDown();

traceo-sdk-core/src/main/java/com/traceo/sdk/logging/client/LogsHandler.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,13 @@ public void process(TraceoLogLevel level, String message, Object... args) {
4141
className = logger.getName();
4242
}
4343

44-
TraceoLog log = new TraceoLog(message, level, className, argsToResources(args));
44+
StringBuilder logMsg = new StringBuilder(String.format("[%s] %s", className, message));
45+
46+
for (Object arg : args) {
47+
logMsg.append(" ").append(arg.toString());
48+
}
49+
50+
TraceoLog log = new TraceoLog(logMsg.toString(), level, className, argsToResources(args));
4551
logsPool.add(log);
4652

4753
if (logsPool.size() >= MAX_LOGS_IN_POOL) {
@@ -73,7 +79,7 @@ public void send() {
7379
}
7480

7581
try {
76-
DefaultRequest<List<TraceoLog>> request = new DefaultRequest<>("/logs", logsPool);
82+
DefaultRequest<List<TraceoLog>> request = new DefaultRequest<>("/api/capture/log", logsPool);
7783
Future<HttpResponse> response = (Future<HttpResponse>) clientOptions.getHttpClient().execute(request);
7884
int statusCode = response.get().getStatusLine().getStatusCode();
7985
if (statusCode == 200) {

traceo-sdk-core/src/main/java/com/traceo/sdk/logging/client/TraceoLogger.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
*/
1313
public class TraceoLogger implements Ilogger {
1414

15-
private static final String BASE_LOGGER_NAME = "TraceoLogger";
15+
private static final String BASE_LOGGER_NAME = "com.traceo.sdk.logging.client.TraceoLogger";
1616

1717
private static ClientOptions clientOptions = new ClientOptions();
1818

traceo-sdk-core/src/main/java/com/traceo/sdk/utils/TimestampUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
public class TimestampUtils {
77

88
public static long getCurrentUnixTimestamp() {
9-
return System.currentTimeMillis() / 1000;
9+
return System.currentTimeMillis();
1010
}
1111

1212
public static String getCurrentTimestamp() {

traceo-sdk/src/test/java/com/traceo/sdk/IncidentHandlerTest.java

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
import com.traceo.sdk.client.TraceoClient;
44
import com.traceo.sdk.client.TraceoClientBuilder;
55
import com.traceo.sdk.client.TraceoClientConfiguration;
6+
import com.traceo.sdk.logging.client.TraceoLogger;
7+
import com.traceo.sdk.utils.TimestampUtils;
68
import org.junit.Before;
79
import org.junit.Test;
810

@@ -12,8 +14,8 @@ public class IncidentHandlerTest {
1214
public void setUp() {
1315
TraceoClientConfiguration configs = TraceoClientBuilder
1416
.standard()
15-
.withApiKey("xxx")
16-
.withHost("https://webhook.site/488164a0-5467-4621-9212-2974cc3eebc7/")
17+
.withApiKey("tr_408917b2-42fb-43d9-8602-861879c1a273")
18+
.withHost("http://localhost:3000")
1719
.withDebug(true)
1820
.withCatchUncaughtException(true)
1921
.build();
@@ -24,11 +26,17 @@ public void setUp() {
2426
@Test
2527
public void testCaptureException() throws ClassNotFoundException {
2628
try {
27-
// throw new NullPointerException("Bardzo fajny exception");
28-
double value = 1 / 0;
29-
System.out.println(value);
30-
} catch (NullPointerException exception) {
31-
// TraceoClient.catchException("CO TO KURWA MA BYĆ", exception);
29+
throw new ArrayIndexOutOfBoundsException();
30+
} catch (ArrayIndexOutOfBoundsException exception) {
31+
TraceoClient.catchException("CO TO KURWA MA BYĆ", exception);
32+
}
33+
}
34+
35+
@Test
36+
public void testLogger() {
37+
TraceoLogger traceoLogger = TraceoClient.getLogger(HttpClientTest.class.getName());
38+
for (int i=0; i< 50; i++) {
39+
traceoLogger.log("xxxxxxxxxxxxxx", "arg1", "arg2", "arg3");
3240
}
3341
}
3442
}

0 commit comments

Comments
 (0)