fix(webapp): preserve columns on clear-filters and read escaped sample paths

- Carry the current cols/hide/sc params through the clear-filters form as hidden inputs so clearing filters no longer wipes a customized column layout.
- Make getAtPath (and labelFromPath) understand the backslash escaping that childPath emits for bracket keys, so picking a sample value whose key contains a quote or backslash resolves instead of showing an empty column. Adds a round-trip test.

Author: ericallam

apps/webapp/app/components/runs/v3/RunFilters.tsx

@@ -406,6 +406,15 @@ export function RunsFilters(props: RunFiltersProps) {
       <FilterMenu {...props} />
       {hasFilters && (
         <Form className="-ml-1 h-6">
+          {searchParams.getAll("cols").map((v, i) => (
+            <input key={`cols-${i}`} type="hidden" name="cols" value={v} />
+          ))}
+          {searchParams.getAll("hide").map((v, i) => (
+            <input key={`hide-${i}`} type="hidden" name="hide" value={v} />
+          ))}
+          {searchParams.getAll("sc").map((v, i) => (
+            <input key={`sc-${i}`} type="hidden" name="sc" value={v} />
+          ))}
           <Button
             variant="minimal/small"
             LeadingIcon={XMarkIcon}

apps/webapp/app/components/runs/v3/smartColumnData.test.ts

@@ -94,6 +94,11 @@ describe("getAtPath", () => {
     expect(getAtPath(obj, "$.a[b]")).toBeUndefined();
   });
 
+  it("reads bracket keys with escaped quotes and backslashes (the form childPath emits)", () => {
+    expect(getAtPath({ "a'b": 1 }, "$['a\\'b']")).toBe(1);
+    expect(getAtPath({ "a\\b": 2 }, "$['a\\\\b']")).toBe(2);
+  });
+
   it("computes a dot-accessed .length for arrays, strings, and objects", () => {
     const data = { tags: ["a", "b", "c"], name: "hello", info: { x: 1, y: 2 }, count: 5 };
     expect(getAtPath(data, "$.tags.length")).toBe(3);

apps/webapp/app/components/runs/v3/smartColumnData.ts

@@ -55,7 +55,12 @@ export function extractSmartValue(parsed: ParsedSource, path: string): SmartCell
   return { state: "value", value };
 }
 
-const PATH_TOKEN_RE = /\.([^.[\]]+)|\[(\d+)\]|\['([^']*)'\]|\["([^"]*)"\]/g;
+const PATH_TOKEN_RE = /\.([^.[\]]+)|\[(\d+)\]|\['((?:\\.|[^'\\])*)'\]|\["((?:\\.|[^"\\])*)"\]/g;
+
+/** Reverse the backslash escaping applied to bracket-notation keys (e.g. `\'` -> `'`). */
+function unescapeBracketKey(raw: string): string {
+  return raw.replace(/\\(.)/g, "$1");
+}
 
 type PathToken =
   | { kind: "dot"; key: string }
@@ -90,8 +95,8 @@ export function getAtPath(root: unknown, path: string): unknown {
 
     if (match[1] !== undefined) tokens.push({ kind: "dot", key: match[1] });
     else if (match[2] !== undefined) tokens.push({ kind: "index", index: Number(match[2]) });
-    else if (match[3] !== undefined) tokens.push({ kind: "key", key: match[3] });
-    else if (match[4] !== undefined) tokens.push({ kind: "key", key: match[4] });
+    else if (match[3] !== undefined) tokens.push({ kind: "key", key: unescapeBracketKey(match[3]) });
+    else if (match[4] !== undefined) tokens.push({ kind: "key", key: unescapeBracketKey(match[4]) });
   }
   if (lastIndex !== normalized.length) return undefined;
 
@@ -129,12 +134,13 @@ export function labelFromPath(path: string): string {
     normalized = `.${normalized}`;
   }
 
-  const re = /\.([^.[\]]+)|\[(\d+)\]|\['([^']*)'\]|\["([^"]*)"\]/g;
+  const re = /\.([^.[\]]+)|\[(\d+)\]|\['((?:\\.|[^'\\])*)'\]|\["((?:\\.|[^"\\])*)"\]/g;
   let lastKey: string | undefined;
   let lastSegment: string | undefined;
   let match: RegExpExecArray | null;
   while ((match = re.exec(normalized)) !== null) {
-    const key = match[1] ?? match[3] ?? match[4];
+    const bracketKey = match[3] ?? match[4];
+    const key = match[1] ?? (bracketKey !== undefined ? unescapeBracketKey(bracketKey) : undefined);
     if (key !== undefined) {
       lastKey = key;
       lastSegment = key;