Added more logging when finalizing runs and when messages don’t exist in marqs

Author: matt-aitken

apps/webapp/app/v3/marqs/index.server.ts

@@ -414,6 +414,10 @@ export class MarQS {
         const message = await this.readMessage(messageId);
 
         if (!message) {
+          logger.log(`[${this.name}].acknowledgeMessage() message not found`, {
+            messageId,
+            service: this.name,
+          });
           return;
         }
 
@@ -553,6 +557,11 @@ export class MarQS {
         const message = await this.readMessage(messageId);
 
         if (!message) {
+          logger.log(`[${this.name}].releaseConcurrency() message not found`, {
+            messageId,
+            releaseForRun,
+            service: this.name,
+          });
           return;
         }
 
@@ -641,6 +650,12 @@ export class MarQS {
         const message = await this.readMessage(messageId);
 
         if (!message) {
+          logger.log(`[${this.name}].nackMessage() message not found`, {
+            messageId,
+            retryAt,
+            updates,
+            service: this.name,
+          });
           return;
         }
 

apps/webapp/app/v3/services/createCheckpoint.server.ts

@@ -176,9 +176,17 @@ export class CreateCheckpointService extends BaseService {
           const result = await resumeService.call({ id: attempt.taskRunId });
 
           if (result.success) {
-            logger.log("CreateCheckpointService: Resumed dependent parents", result);
+            logger.log("CreateCheckpointService: Resumed dependent parents", {
+              result,
+              attempt,
+              checkpointEvent,
+            });
           } else {
-            logger.error("CreateCheckpointService: Failed to resume dependent parents", result);
+            logger.error("CreateCheckpointService: Failed to resume dependent parents", {
+              result,
+              attempt,
+              checkpointEvent,
+            });
           }
 
           return {

apps/webapp/app/v3/services/finalizeTaskRun.server.ts

@@ -75,9 +75,9 @@ export class FinalizeTaskRunService extends BaseService {
     const result = await resumeService.call({ id: run.id });
 
     if (result.success) {
-      logger.log("FinalizeTaskRunService: Resumed dependent parents", { result });
+      logger.log("FinalizeTaskRunService: Resumed dependent parents", { result, run });
     } else {
-      logger.error("FinalizeTaskRunService: Failed to resume dependent parents", { result });
+      logger.error("FinalizeTaskRunService: Failed to resume dependent parents", { result, run });
     }
 
     //enqueue alert