fix(webapp): keep copy button tabbable and stop timed-out alert seed writing late

Review feedback on #4359: the copy affordance sat inside a tooltip trigger
that forced tabIndex -1, so keyboard users could not reach it; pass tabbable
through. The default-alerts seed could also complete its write after the 5s
timeout fired and overwrite a user's first alert edit; the timeout now aborts
the seed before it writes. A fully atomic create-if-absent needs a platform
API change and is out of scope here.

Author: kathiekiwi

apps/webapp/app/components/primitives/CopyableText.tsx

@@ -66,11 +66,13 @@ export function CopyableText({
           iconButton
         ) : (
           // asChild so the Radix trigger merges onto our button instead of nesting a button.
+          // tabbable keeps the button in the tab order (the trigger sets tabIndex -1 otherwise).
           <SimpleTooltip
             button={iconButton}
             content={copied ? "Copied!" : "Copy"}
             className="font-sans"
             disableHoverableContent
+            tabbable
             asChild
           />
         )}

apps/webapp/app/models/organization.server.ts

@@ -146,13 +146,19 @@ async function seedDefaultBillingAlerts(organizationId: string): Promise<void> {
   }
 
   let timer: NodeJS.Timeout | undefined;
+  const abort = new AbortController();
   const timeout = new Promise<never>((_, reject) => {
-    timer = setTimeout(() => reject(new Error("Timed out")), SEED_ALERTS_TIMEOUT_MS);
+    timer = setTimeout(() => {
+      // Stop the seed from writing after we give up: by then the user may have
+      // saved their own alerts, and a late default write would clobber them.
+      abort.abort();
+      reject(new Error("Timed out"));
+    }, SEED_ALERTS_TIMEOUT_MS);
   });
 
   const [error] = await tryCatch(
-    Promise.race([writeDefaultBillingAlertsIfUnset(organizationId), timeout]).finally(() =>
-      clearTimeout(timer)
+    Promise.race([writeDefaultBillingAlertsIfUnset(organizationId, abort.signal), timeout]).finally(
+      () => clearTimeout(timer)
     )
   );
   if (error) {
@@ -166,13 +172,25 @@ async function seedDefaultBillingAlerts(organizationId: string): Promise<void> {
 /**
  * Only writes defaults when the org has no alerts yet. A slow seed that finishes
  * after org creation returned would otherwise overwrite the user's first alert edit.
+ *
+ * The read-then-write isn't atomic: the platform API has no conditional write and
+ * returns the same empty-levels shape for "no record" and "record cleared by the
+ * user". Both only matter inside the seconds-long seed window right after org
+ * creation; the abort check below keeps a timed-out seed from writing late.
  */
-async function writeDefaultBillingAlertsIfUnset(organizationId: string): Promise<void> {
+async function writeDefaultBillingAlertsIfUnset(
+  organizationId: string,
+  signal: AbortSignal
+): Promise<void> {
   const existing = await getBillingAlerts(organizationId);
   if (existing && existing.alertLevels.length > 0) {
     return;
   }
 
+  if (signal.aborted) {
+    return;
+  }
+
   await setBillingAlert(organizationId, buildDefaultBillingAlerts());
 }