Commit 7f01aaf
committed
fix(run-engine): re-register the TTL entry when the vtime dequeue expires a run
The vtime dequeue is a copy of dequeueMessagesFromCkQueueTracked, and main
added a TTL re-registration to that command while this branch was open. A copy
cannot pick up a change to its original, so the rebase left the vtime path
behind: it drops an expired run from the queue sorted sets and defers to a TTL
consumer that has no entry for it, because the entry is removed on first
dequeue. The run is then orphaned.
Only reachable with the flag on, so nothing shipped, but it would have gone out
with the feature. Same four lines as the base command, verbatim; the expired
branch is now identical between the two again.
Copies drifting like this is a known cost of the vtime scripts being copies,
kept deliberately so the flag-off path stays byte-identical to production. The
drift is worth a test that pins each copy against its original, which would
have caught this the day main merged.1 parent 188a443 commit 7f01aaf
1 file changed
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5526 | 5526 | | |
5527 | 5527 | | |
5528 | 5528 | | |
| 5529 | + | |
| 5530 | + | |
| 5531 | + | |
| 5532 | + | |
5529 | 5533 | | |
5530 | 5534 | | |
5531 | 5535 | | |
| |||
0 commit comments