Commit 99edcb2
committed
fix(webapp): correct webhook delivery empty-state and sample-picker loading
Two webhook dashboard views showed a misleading state.
An empty deliveries list always rendered 'No deliveries match these filters'
because the detail routes default the window to 7 days, so the presenter treated
that default as an active filter. It now derives hasFilters from whether the user
explicitly set a window, so a webhook that has never received anything shows the
real empty state.
The sample-event picker treated the provider list as loaded before its fetch had
started, flashing 'No providers' on first open. It now shows the spinner until
the data arrives.1 parent 46da2cb commit 99edcb2
4 files changed
Lines changed: 6 additions & 2 deletions
File tree
- apps/webapp/app
- components/webhookConsole
- presenters/v3
- routes
- _app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.webhooks.$webhookParam
- _app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.webhooks.endpoints.$endpointParam
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| |||
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
577 | 577 | | |
578 | 578 | | |
579 | 579 | | |
| 580 | + | |
580 | 581 | | |
581 | 582 | | |
582 | 583 | | |
| |||
587 | 588 | | |
588 | 589 | | |
589 | 590 | | |
| 591 | + | |
590 | 592 | | |
591 | 593 | | |
592 | 594 | | |
| |||
640 | 642 | | |
641 | 643 | | |
642 | 644 | | |
643 | | - | |
| 645 | + | |
644 | 646 | | |
645 | 647 | | |
646 | 648 | | |
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
| 181 | + | |
181 | 182 | | |
182 | 183 | | |
183 | 184 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
| 134 | + | |
134 | 135 | | |
135 | 136 | | |
136 | 137 | | |
| |||
0 commit comments