Skip to content

Commit b79642a

Browse files
samejrmatt-aitken
authored andcommitted
Adds a classname to override the value in the filters
1 parent edab60b commit b79642a

3 files changed

Lines changed: 16 additions & 5 deletions

File tree

apps/webapp/app/components/primitives/AppliedFilter.tsx

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ type AppliedFilterProps = {
2727
onRemove?: () => void;
2828
variant?: Variant;
2929
className?: string;
30+
valueClassName?: string;
3031
};
3132

3233
export function AppliedFilter({
@@ -37,6 +38,7 @@ export function AppliedFilter({
3738
onRemove,
3839
variant = "secondary/small",
3940
className,
41+
valueClassName,
4042
}: AppliedFilterProps) {
4143
const variantClassName = variants[variant];
4244
return (
@@ -48,14 +50,18 @@ export function AppliedFilter({
4850
className
4951
)}
5052
>
51-
<div className={cn("flex items-start leading-4", label === undefined ? "gap-1.5" : "gap-0.5")}>
53+
<div
54+
className={cn("flex items-start leading-4", label === undefined ? "gap-1.5" : "gap-0.5")}
55+
>
5256
<div className="-mt-[0.5px] flex items-center gap-1">
5357
{icon}
54-
{label && <div className="text-text-bright">
55-
<span>{label}</span>:
56-
</div>}
58+
{label && (
59+
<div className="text-text-bright">
60+
<span>{label}</span>:
61+
</div>
62+
)}
5763
</div>
58-
<div className="text-text-dimmed">
64+
<div className={cn("text-text-dimmed", valueClassName)}>
5965
<div>{value}</div>
6066
</div>
6167
</div>

apps/webapp/app/components/runs/v3/SharedFilters.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -348,6 +348,8 @@ export interface TimeFilterProps {
348348
onValueChange?: (values: TimeFilterApplyValues) => void;
349349
/** When set an upgrade message will be shown if you select a period further back than this number of days */
350350
maxPeriodDays?: number;
351+
/** Optional className override for the value text in the filter pill */
352+
valueClassName?: string;
351353
}
352354

353355
export function TimeFilter({
@@ -360,6 +362,7 @@ export function TimeFilter({
360362
applyShortcut,
361363
onValueChange,
362364
maxPeriodDays,
365+
valueClassName,
363366
}: TimeFilterProps = {}) {
364367
const { value } = useSearchParams();
365368
const periodValue = period ?? value("period");
@@ -386,6 +389,7 @@ export function TimeFilter({
386389
value={constrained.valueLabel}
387390
removable={false}
388391
variant="secondary/small"
392+
valueClassName={valueClassName}
389393
/>
390394
</Ariakit.Select>
391395
}

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.metrics.$dashboardKey/route.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ export function MetricDashboard({
164164
labelName="Period"
165165
hideLabel
166166
maxPeriodDays={maxPeriodDays}
167+
valueClassName="text-text-bright"
167168
/>
168169
</div>
169170
<div

0 commit comments

Comments
 (0)