refactor: Extract types out of store

Author: ptbrowne

app/flags/flag.tsx

@@ -2,7 +2,8 @@ import qs from "qs";
 
 import { isRunningInBrowser } from "@/utils/is-running-in-browser";
 
-import FlagStore, { FlagName, FlagValue } from "./store";
+import FlagStore from "./store";
+import { FlagName, FlagValue } from "./types";
 
 const FLAG_PREFIX = "flag__";
 

app/flags/ls-adapter.ts

@@ -1,4 +1,4 @@
-import { FlagName, FlagValue } from "./store";
+import { FlagName, FlagValue } from "./types";
 
 export const prefix = "flag__";
 export const getKey = (name: FlagName) => prefix + name;

app/flags/store.ts

@@ -1,20 +1,7 @@
 import mitt, { Emitter } from "mitt";
 
 import lsAdapter from "./ls-adapter";
-
-export type FlagValue = any;
-
-export type FlagName =
-  /** Whether we can search by termsets */
-  | "search.termsets"
-  /** Whether we can add dataset from shared dimensions */
-  | "configurator.add-dataset.shared"
-  /** Whether we can add a new dataset */
-  | "configurator.add-dataset.new"
-  /** Whether we can use the free canvas dashboard layout */
-  | "layouter.dashboard.free-canvas"
-  /** Whether we can use shared filters on dashboard layout */
-  | "layouter.dashboard.shared-filters";
+import { FlagName, FlagValue } from "./types";
 
 type Events = { change: string };
 /**

app/flags/types.ts

@@ -0,0 +1,13 @@
+export type FlagValue = any;
+
+export type FlagName =
+  /** Whether we can search by termsets */
+  | "search.termsets"
+  /** Whether we can add dataset from shared dimensions */
+  | "configurator.add-dataset.shared"
+  /** Whether we can add a new dataset */
+  | "configurator.add-dataset.new"
+  /** Whether we can use the free canvas dashboard layout */
+  | "layouter.dashboard.free-canvas"
+  /** Whether we can use shared filters on dashboard layout */
+  | "layouter.dashboard.shared-filters";

app/flags/useFlag.ts

@@ -1,8 +1,7 @@
 import { useEffect, useState } from "react";
 
-import { FlagName } from "@/flags/store";
-
 import { flag } from "./flag";
+import { FlagName } from "./types";
 
 export default function useFlag(name: FlagName) {
   const [flagValue, setFlag] = useState(() => flag(name));