Skip to content

Commit 2497f2e

Browse files
committed
feat: Diminish banner height
1 parent 94cebc4 commit 2497f2e

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

app/configurator/components/presence.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,11 @@ export const navPresenceProps = {
3636
exit: "exit",
3737
};
3838

39+
export const BANNER_HEIGHT = 250;
40+
export const BANNER_MARGIN_TOP = 96;
3941
export const bannerPresenceProps: Transition = {
4042
transition: { duration: 0.5 },
41-
initial: { marginTop: -446 },
42-
animate: { marginTop: 96 },
43-
exit: { marginTop: -446 },
43+
initial: { marginTop: -(BANNER_HEIGHT + BANNER_MARGIN_TOP) },
44+
animate: { marginTop: BANNER_MARGIN_TOP },
45+
exit: { marginTop: -(BANNER_HEIGHT + BANNER_MARGIN_TOP) },
4446
};

app/configurator/components/select-dataset-step.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ import {
2929
} from "@/configurator/components/layout";
3030
import {
3131
bannerPresenceProps,
32+
BANNER_HEIGHT,
33+
BANNER_MARGIN_TOP,
3234
MotionBox,
3335
navPresenceProps,
3436
smoothPresenceProps,
@@ -81,8 +83,8 @@ const useStyles = makeStyles<Theme, { datasetPresent: boolean }>((theme) => ({
8183
gridTemplateColumns:
8284
"minmax(12rem, 20rem) minmax(22rem, 1fr) minmax(12rem, 20rem)",
8385
gridTemplateAreas: `". banner ."`,
84-
height: 350,
85-
marginTop: 96,
86+
height: BANNER_HEIGHT,
87+
marginTop: BANNER_MARGIN_TOP,
8688
backgroundColor: theme.palette.primary.light,
8789
},
8890
panelBanner: {

0 commit comments

Comments
 (0)