Skip to content

Commit 2dd9fd3

Browse files
authored
Merge pull request #1578 from visualize-admin/chore/clean-up
chore: Use npx knip to clean up unused things
2 parents be29e56 + 6fc1cbe commit 2dd9fd3

71 files changed

Lines changed: 119 additions & 1129 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

app/browser/dataset-browse.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -515,7 +515,7 @@ const NavItem = ({
515515
);
516516
};
517517

518-
export const Subthemes = ({
518+
const Subthemes = ({
519519
subthemes,
520520
filters,
521521
counts,
@@ -556,7 +556,7 @@ type NavSectionTitleTheme = {
556556
borderColor: string;
557557
};
558558

559-
export const NavSectionTitle = ({
559+
const NavSectionTitle = ({
560560
children,
561561
theme,
562562
...flexProps
@@ -990,7 +990,7 @@ const useResultStyles = makeStyles((theme: Theme) => ({
990990
},
991991
}));
992992

993-
export const DateFormat = ({ date }: { date: string }) => {
993+
const DateFormat = ({ date }: { date: string }) => {
994994
const formatter = useFormatDate();
995995
const formatted = useMemo(() => {
996996
return formatter(date);

app/browser/select-dataset-step.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ const useStyles = makeStyles<
130130
},
131131
}));
132132

133-
export const formatBackLink = (
133+
const formatBackLink = (
134134
query: Router["query"]
135135
): React.ComponentProps<typeof NextLink>["href"] => {
136136
const backParameters = softJSONParse(query.previous as string);

app/charts/area/chart-area.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export const ChartAreasVisualization = (
2525
return <ChartDataWrapper {...props} Component={ChartAreas} />;
2626
};
2727

28-
export const ChartAreas = memo((props: ChartProps<AreaConfig>) => {
28+
const ChartAreas = memo((props: ChartProps<AreaConfig>) => {
2929
const { chartConfig } = props;
3030
const { fields, interactiveFiltersConfig } = chartConfig;
3131

app/charts/column/chart-column.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export const ChartColumnsVisualization = (
3636
return <ChartDataWrapper {...props} Component={ChartColumns} />;
3737
};
3838

39-
export const ChartColumns = memo((props: ChartProps<ColumnConfig>) => {
39+
const ChartColumns = memo((props: ChartProps<ColumnConfig>) => {
4040
const { chartConfig, dimensions } = props;
4141
const { fields, interactiveFiltersConfig } = chartConfig;
4242
const filters = useChartConfigFilters(chartConfig);

app/charts/combo/chart-combo-line-column.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export const ChartComboLineColumnVisualization = (
2222
return <ChartDataWrapper {...props} Component={ChartComboLineColumn} />;
2323
};
2424

25-
export const ChartComboLineColumn = memo(
25+
const ChartComboLineColumn = memo(
2626
(props: ChartProps<ComboLineColumnConfig>) => {
2727
const { chartConfig } = props;
2828
const { interactiveFiltersConfig } = chartConfig;

app/charts/combo/chart-combo-line-dual.tsx

Lines changed: 24 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -22,30 +22,28 @@ export const ChartComboLineDualVisualization = (
2222
return <ChartDataWrapper {...props} Component={ChartComboLineDual} />;
2323
};
2424

25-
export const ChartComboLineDual = memo(
26-
(props: ChartProps<ComboLineDualConfig>) => {
27-
const { chartConfig } = props;
28-
const { interactiveFiltersConfig } = chartConfig;
29-
const { sharedFilters } = useDashboardInteractiveFilters();
25+
const ChartComboLineDual = memo((props: ChartProps<ComboLineDualConfig>) => {
26+
const { chartConfig } = props;
27+
const { interactiveFiltersConfig } = chartConfig;
28+
const { sharedFilters } = useDashboardInteractiveFilters();
3029

31-
return (
32-
<ComboLineDualChart {...props}>
33-
<ChartContainer type="comboLineDual">
34-
<ChartSvg>
35-
<AxisHeightLinearDual orientation="left" />
36-
<AxisHeightLinearDual orientation="right" /> <AxisTime />
37-
<AxisTimeDomain />
38-
<ComboLineDual />
39-
<InteractionHorizontal />
40-
{shouldShowBrush(interactiveFiltersConfig, sharedFilters) && (
41-
<BrushTime />
42-
)}
43-
</ChartSvg>
44-
<HoverDotMultiple />
45-
<Ruler />
46-
<Tooltip type="multiple" />
47-
</ChartContainer>
48-
</ComboLineDualChart>
49-
);
50-
}
51-
);
30+
return (
31+
<ComboLineDualChart {...props}>
32+
<ChartContainer type="comboLineDual">
33+
<ChartSvg>
34+
<AxisHeightLinearDual orientation="left" />
35+
<AxisHeightLinearDual orientation="right" /> <AxisTime />
36+
<AxisTimeDomain />
37+
<ComboLineDual />
38+
<InteractionHorizontal />
39+
{shouldShowBrush(interactiveFiltersConfig, sharedFilters) && (
40+
<BrushTime />
41+
)}
42+
</ChartSvg>
43+
<HoverDotMultiple />
44+
<Ruler />
45+
<Tooltip type="multiple" />
46+
</ChartContainer>
47+
</ComboLineDualChart>
48+
);
49+
});

app/charts/combo/chart-combo-line-single.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export const ChartComboLineSingleVisualization = (
2727
return <ChartDataWrapper {...props} Component={ChartComboLineSingle} />;
2828
};
2929

30-
export const ChartComboLineSingle = memo(
30+
const ChartComboLineSingle = memo(
3131
(props: ChartProps<ComboLineSingleConfig>) => {
3232
const { chartConfig, measures } = props;
3333
const { interactiveFiltersConfig } = chartConfig;

app/charts/index.ts

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ import { createChartId } from "@/utils/create-chart-id";
8989
import { isMultiHierarchyNode } from "@/utils/hierarchy";
9090
import { unreachableError } from "@/utils/unreachable";
9191

92-
export const chartTypes: ChartType[] = [
92+
const chartTypes: ChartType[] = [
9393
"column",
9494
"line",
9595
"area",
@@ -112,7 +112,7 @@ export const regularChartTypes: RegularChartType[] = [
112112
"map",
113113
];
114114

115-
export const comboDifferentUnitChartTypes: ComboChartType[] = [
115+
const comboDifferentUnitChartTypes: ComboChartType[] = [
116116
"comboLineDual",
117117
"comboLineColumn",
118118
];
@@ -125,11 +125,7 @@ export const comboChartTypes: ComboChartType[] = [
125125
];
126126

127127
type ChartOrder = { [k in ChartType]: number };
128-
export function getChartTypeOrder({
129-
cubeCount,
130-
}: {
131-
cubeCount: number;
132-
}): ChartOrder {
128+
function getChartTypeOrder({ cubeCount }: { cubeCount: number }): ChartOrder {
133129
const multiCubeBoost = cubeCount > 1 ? -100 : 0;
134130
return {
135131
column: 0,
@@ -284,7 +280,7 @@ export const initializeMapLayerField = ({
284280
}
285281
};
286282

287-
export const getInitialAreaLayer = ({
283+
const getInitialAreaLayer = ({
288284
component,
289285
measure,
290286
}: {
@@ -307,7 +303,7 @@ export const getInitialAreaLayer = ({
307303
};
308304
};
309305

310-
export const getInitialSymbolLayer = ({
306+
const getInitialSymbolLayer = ({
311307
component,
312308
measure,
313309
}: {

app/charts/line/chart-lines.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export const ChartLinesVisualization = (
2727
return <ChartDataWrapper {...props} Component={ChartLines} />;
2828
};
2929

30-
export const ChartLines = memo((props: ChartProps<LineConfig>) => {
30+
const ChartLines = memo((props: ChartProps<LineConfig>) => {
3131
const { chartConfig } = props;
3232
const { fields, interactiveFiltersConfig } = chartConfig;
3333
const { sharedFilters } = useDashboardInteractiveFilters();

app/charts/map/chart-map.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ export type ChartMapProps = ChartProps<MapConfig> & {
128128
coordinates: GeoCoordinates | undefined;
129129
};
130130

131-
export const ChartMap = memo((props: ChartMapProps) => {
131+
const ChartMap = memo((props: ChartMapProps) => {
132132
const { chartConfig, dimensions, observations } = props;
133133
const { fields } = chartConfig;
134134
const filters = useChartConfigFilters(chartConfig);

0 commit comments

Comments
 (0)