Skip to content

Commit 443a77f

Browse files
committed
fix: Can show numerical measure in table configurator
1 parent 67e5d08 commit 443a77f

2 files changed

Lines changed: 20 additions & 13 deletions

File tree

app/configurator/components/chart-options-selector.tsx

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -107,15 +107,17 @@ export const ChartOptionsSelector = ({
107107
if (metadataData?.dataCubeByIri) {
108108
return {
109109
...metadataData.dataCubeByIri,
110-
dimensions: [
111-
// There are no fields that make use of numeric dimensions at the moment.
112-
...metadataData.dataCubeByIri.dimensions.filter(
113-
(d) => !d.isNumerical
114-
),
115-
],
110+
dimensions: isTableConfig(chartConfig)
111+
? metadataData.dataCubeByIri.dimensions
112+
: [
113+
// There are no fields that make use of numeric dimensions at the moment.
114+
...metadataData.dataCubeByIri.dimensions.filter(
115+
(d) => !d.isNumerical
116+
),
117+
],
116118
};
117119
}
118-
}, [metadataData?.dataCubeByIri]);
120+
}, [chartConfig, metadataData?.dataCubeByIri]);
119121

120122
if (metaData) {
121123
return (

app/configurator/table/table-chart-options.tsx

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { t, Trans } from "@lingui/macro";
2-
import { Box } from "@mui/material";
2+
import { Box, Alert, Typography } from "@mui/material";
33
import get from "lodash/get";
44
import React, { ChangeEvent, useCallback, useEffect, useRef } from "react";
55

@@ -41,6 +41,7 @@ import {
4141
import {
4242
canDimensionBeMultiFiltered,
4343
isNumericalMeasure,
44+
isStandardErrorDimension,
4445
isTemporalDimension,
4546
} from "@/domain/data";
4647
import { DimensionMetadataFragment } from "@/graphql/query-hooks";
@@ -165,12 +166,15 @@ export const TableColumnOptions = ({
165166
}
166167

167168
// Active field is always a component IRI, like in filters
168-
const component =
169-
metaData.dimensions.find((d) => d.iri === activeField) ??
170-
metaData.measures.find((d) => d.iri === activeField);
169+
const allComponents = [...metaData.dimensions, ...metaData.measures];
170+
const component = allComponents.find((d) => d.iri === activeField);
171171

172172
if (!component) {
173-
return <div>`No component ${activeField}`</div>;
173+
return (
174+
<Alert icon={false} severity="error">
175+
<Typography variant="body2">No component {activeField}</Typography>
176+
</Alert>
177+
);
174178
}
175179

176180
const { isGroup, isHidden } = chartConfig.fields[activeField];
@@ -308,7 +312,8 @@ export const TableColumnOptions = ({
308312
</ControlSectionContent>
309313
</ControlSection>
310314
)}
311-
{canDimensionBeMultiFiltered(component) ? (
315+
{canDimensionBeMultiFiltered(component) &&
316+
!isStandardErrorDimension(component) ? (
312317
<ControlSection>
313318
<SectionTitle disabled={!component} iconName="filter">
314319
<Trans id="controls.section.filter">Filter</Trans>

0 commit comments

Comments
 (0)