Skip to content

Commit 50ea5f8

Browse files
committed
fix: Remove interactive filters section if nothing is to be shown there
1 parent fad5625 commit 50ea5f8

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

app/configurator/interactive-filters/interactive-filters-configurator.tsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,18 @@ export const InteractiveFiltersConfigurator = ({
7171
});
7272

7373
const canFilterTimeRange =
74+
isTemporalDimension(xComponent) &&
7475
chartConfigOptionsUISpec[chartType].interactiveFilters.includes(
7576
"timeRange"
7677
);
78+
7779
const canFilterTimeSlider =
7880
ENABLE_TIME_SLIDER && timeSliderDimensions.length > 0;
7981

82+
if (!canFilterTimeRange && !canFilterTimeSlider) {
83+
return null;
84+
}
85+
8086
return (
8187
<ControlSection
8288
role="tablist"
@@ -94,11 +100,11 @@ export const InteractiveFiltersConfigurator = ({
94100
</SectionTitle>
95101
<ControlSectionContent px="small" gap="none">
96102
{/* Time range */}
97-
{isTemporalDimension(xComponent) && canFilterTimeRange && (
103+
{canFilterTimeRange && (
98104
<InteractiveFilterTabField
99105
value="timeRange"
100106
icon="time"
101-
label={xComponent.label}
107+
label={xComponent!.label}
102108
/>
103109
)}
104110
{/* Time slider */}

0 commit comments

Comments
 (0)