Skip to content

Commit 60177bc

Browse files
committed
chore: assign todos
1 parent 21259b3 commit 60177bc

3 files changed

Lines changed: 10 additions & 8 deletions

File tree

packages/vite/src/app/components/data/ChunkDetails.vue

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ withDefaults(defineProps<{
2020
<div i-ph-shapes-duotone />
2121
<div>{{ chunk.name || '[unnamed]' }}</div>
2222
<DisplayBadge :text="chunk.reason" />
23+
<!-- TODO: Estimated Chunk Size -->
2324
</div>
2425

2526
<div flex-auto />
@@ -54,6 +55,8 @@ withDefaults(defineProps<{
5455
</div>
5556
</details>
5657

58+
<!-- TODO: imports seems to be "imported-by" instead of "imports", maybe something wrong on Rolldown side? -->
59+
<!-- TODO: We might want to display both "imports" and "imported-by" relationship -->
5760
<details v-if="showImports && chunk.imports.length > 0" open="true">
5861
<summary op50>
5962
<span>Imports ({{ chunk.imports.length }})</span>

packages/vite/src/app/components/data/SearchPanel.vue

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -102,28 +102,25 @@ function unselectToggle() {
102102
<div text-sm>{{ rule.description || rule.name }}</div>
103103
</label>
104104
<button
105-
rounded-md px2 py1
105+
rounded-md p1
106106
flex="~ items-center gap-1"
107107
select-none
108108
hover="bg-active"
109109
title="Reverse Selection"
110110
@click="reverseSelect"
111111
>
112-
<div text-xs op50>
113-
Reverse
114-
</div>
112+
<div op75 i-ph-selection-background-duotone />
115113
</button>
116114
<button
117-
rounded-md px2 py1
115+
rounded-md p1
118116
flex="~ items-center gap-1"
119117
select-none
120118
hover="bg-active"
121119
:title="model.selected?.length === 0 ? 'Select All' : 'Unselect All'"
122120
@click="unselectToggle"
123121
>
124-
<div text-xs op50>
125-
{{ model.selected?.length === 0 ? 'Select All' : 'Unselect All' }}
126-
</div>
122+
<div v-if="model.selected?.length === 0" op75 i-ph-selection-slash-duotone />
123+
<div v-else op75 i-ph-selection-plus-duotone />
127124
</button>
128125
</div>
129126
<slot />

packages/vite/src/app/pages/session/[session]/chunks.vue

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ function toggleDisplay(type: ClientSettings['chunkViewType']) {
5858
<div :class="viewType.icon" />
5959
{{ viewType.label }}
6060
</button>
61+
<!-- TODO: add graph views -->
6162
</div>
6263
</div>
6364
<template v-if="settings.chunkViewType === 'list'">
@@ -73,6 +74,7 @@ function toggleDisplay(type: ClientSettings['chunkViewType']) {
7374
</div>
7475
</template>
7576
<template v-else-if="settings.chunkViewType === 'graph'">
77+
<!-- TODO: We should draw a deep-first graph instead of flat graph -->
7678
<ChunksGraph
7779
:session="session"
7880
:chunks="normalizedChunks"

0 commit comments

Comments
 (0)