fix(core): support IPv6 in devtools server link (#204)

Author: webfansplz

packages/core/src/node/__tests__/utils.test.ts

@@ -0,0 +1,16 @@
+import { describe, expect, it } from 'vitest'
+import { normalizeHttpServerUrl } from '../utils'
+
+describe('normalizeHttpServerUrl', () => {
+  it('formats ipv4 localhost as localhost', () => {
+    expect(normalizeHttpServerUrl('127.0.0.1', 9999)).toBe('http://localhost:9999')
+  })
+
+  it('wraps ipv6 hosts in brackets', () => {
+    expect(normalizeHttpServerUrl('::1', 9999)).toBe('http://[::1]:9999')
+  })
+
+  it('preserves non-ip hosts', () => {
+    expect(normalizeHttpServerUrl('localhost', 9999)).toBe('http://localhost:9999')
+  })
+})

packages/core/src/node/cli-commands.ts

@@ -23,6 +23,7 @@ import { renderDockImportsMap } from './plugins/server'
 import { createDevToolsMiddleware } from './server'
 import { startStandaloneDevTools } from './standalone'
 import { collectStaticRpcDump } from './static-dump'
+import { normalizeHttpServerUrl } from './utils'
 
 export interface StartOptions {
   root?: string
@@ -68,9 +69,10 @@ export async function start(options: StartOptions) {
   const server = createServer(toNodeListener(app))
 
   server.listen(port, host, async () => {
-    console.log(c.green`${MARK_NODE} Vite DevTools started at`, c.green(`http://${host === '127.0.0.1' ? 'localhost' : host}:${port}`), '\n')
+    const url = normalizeHttpServerUrl(host, port)
+    console.log(c.green`${MARK_NODE} Vite DevTools started at`, c.green(url), '\n')
     if (options.open)
-      await open(`http://${host === '127.0.0.1' ? 'localhost' : host}:${port}`)
+      await open(url)
   })
 }
 

packages/core/src/node/utils.ts

@@ -1,3 +1,16 @@
+import { isIP } from 'node:net'
+
 export function isObject(value: unknown): value is Record<string, any> {
   return Object.prototype.toString.call(value) === '[object Object]'
 }
+
+export function normalizeHttpServerUrl(host: string, port: number | string): string {
+  const normalizedHost
+    = host === '127.0.0.1'
+      ? 'localhost'
+      : isIP(host) === 6
+        ? `[${host}]`
+        : host
+
+  return `http://${normalizedHost}:${port}`
+}