From 3b48f36c5a279e4047349b9c93f00eb908b9f760 Mon Sep 17 00:00:00 2001 From: "voidzero-bot[bot]" <348775505+voidzero-bot[bot]@users.noreply.github.com> Date: Tue, 17 Nov 2026 07:26:40 +0000 Subject: [PATCH] fix(cli): track TSRS_LINT_RUN_EXTERNAL_CODE for type-aware lint caching and document it --- docs/guide/lint.md | 8 +++++++ packages/cli/binding/src/cli/handler.rs | 5 +++- packages/cli/binding/src/cli/resolver.rs | 29 +++++++++++++++++++++++- 3 files changed, 40 insertions(+), 2 deletions(-) diff --git a/docs/guide/lint.md b/docs/guide/lint.md index cedda76249..e90ba21b3e 100644 --- a/docs/guide/lint.md +++ b/docs/guide/lint.md @@ -51,6 +51,14 @@ We recommend enabling both `typeAware` and `typeCheck` in the `lint` block: Vite+ uses [tsrs](https://github.com/oxc-project/tsrs), a Rust port of the TypeScript 7 compiler. Its `tsrs-lint` executable gives Oxlint access to type information and allows type checking directly via `vp lint` and `vp check`. +### Content Mappers + +Projects that use `tsconfig.json` `contentMappers` (for example `vize` for `.vue` files) must opt in to running external mapper packages. Set the environment variable that the bundled `tsrs-lint` backend reads before running `vp lint`: + +```bash +TSRS_LINT_RUN_EXTERNAL_CODE=1 vp lint +``` + ## JS Plugins If you are migrating from ESLint and still depend on a few critical JavaScript-based ESLint plugins, Oxlint has [JS plugin support](https://oxc.rs/docs/guide/usage/linter/js-plugins) that can help you keep those plugins running while you complete the migration. diff --git a/packages/cli/binding/src/cli/handler.rs b/packages/cli/binding/src/cli/handler.rs index e49b5c9988..0facce4e7d 100644 --- a/packages/cli/binding/src/cli/handler.rs +++ b/packages/cli/binding/src/cli/handler.rs @@ -83,7 +83,10 @@ impl CommandHandler for VitePlusCommandHandler { // Check is a composite command (fmt + lint) — run as a subprocess in task scripts Ok(HandledCommand::Synthesized(command.to_synthetic_plan_request( UserCacheConfig::with_config(EnabledCacheConfig { - env: Some(Box::new([Str::from("OXLINT_TSGOLINT_PATH")])), + env: Some(Box::new([ + Str::from("OXLINT_TSGOLINT_PATH"), + Str::from("TSRS_LINT_RUN_EXTERNAL_CODE"), + ])), untracked_env: None, input: Some(check_cache_inputs()), output: None, diff --git a/packages/cli/binding/src/cli/resolver.rs b/packages/cli/binding/src/cli/resolver.rs index c9c9230c7e..afdd2b4b82 100644 --- a/packages/cli/binding/src/cli/resolver.rs +++ b/packages/cli/binding/src/cli/resolver.rs @@ -94,7 +94,10 @@ impl SubcommandResolver { .chain(args.into_iter().map(Str::from)) .collect(), cache_config: UserCacheConfig::with_config(EnabledCacheConfig { - env: Some(Box::new([Str::from("OXLINT_TSGOLINT_PATH")])), + env: Some(Box::new([ + Str::from("OXLINT_TSGOLINT_PATH"), + Str::from("TSRS_LINT_RUN_EXTERNAL_CODE"), + ])), untracked_env: None, input: None, output: None, @@ -425,4 +428,28 @@ mod tests { } } } + + #[tokio::test] + async fn lint_tracks_backend_env_vars_for_caching() { + let temp = tempfile::tempdir().unwrap(); + let root = AbsolutePathBuf::new(temp.path().to_path_buf()).unwrap(); + let resolver = SubcommandResolver::new(root.clone().into()) + .with_cli_options(cli_options(Arc::from(OsStr::new("node")))); + let envs = Arc::new(EnvMap::default()); + + let resolved = resolver + .resolve(SynthesizableSubcommand::Lint { args: vec![] }, &envs, &root) + .await + .unwrap(); + + let tracked_envs: Vec = resolved + .cache_config + .into_enabled() + .and_then(|cfg| { + cfg.env.map(|envs| envs.iter().map(|env| env.as_str().to_string()).collect()) + }) + .unwrap_or_default(); + assert!(tracked_envs.iter().any(|env| env == "OXLINT_TSGOLINT_PATH")); + assert!(tracked_envs.iter().any(|env| env == "TSRS_LINT_RUN_EXTERNAL_CODE")); + } }