Skip to content

Commit 2ffabd6

Browse files
committed
Release untimed oracle state before measuring PCO workloads
Signed-off-by: Daniel King <dan@spiraldb.com>
1 parent 1ac85fa commit 2ffabd6

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

‎encodings/pco/benches/selection.rs‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ fn write(bencher: Bencher, nullable: bool) {
6666
let written =
6767
Pco::from_primitive(input.as_view(), 3, 1024, &mut check).vortex_expect("write oracle");
6868
assert_arrays_eq!(written.into_array(), input.clone(), &mut check);
69+
drop(check);
6970
bencher
7071
.with_inputs(|| SESSION.create_execution_ctx())
7172
.bench_refs(|ctx| {
@@ -78,6 +79,7 @@ fn full(bencher: Bencher, nullable: bool) {
7879
let source = compressed(nullable);
7980
let mut check = SESSION.create_execution_ctx();
8081
assert_arrays_eq!(source.clone(), input(nullable), &mut check);
82+
drop(check);
8183
bencher
8284
.with_inputs(|| SESSION.create_execution_ctx())
8385
.bench_refs(|ctx| {
@@ -137,6 +139,8 @@ fn selection(bencher: Bencher, (kind, nullable): (&str, bool)) {
137139
}
138140
.vortex_expect("primitive oracle");
139141
assert_arrays_eq!(actual, expected, &mut check);
142+
drop(reference);
143+
drop(check);
140144
bencher
141145
.with_inputs(|| SESSION.create_execution_ctx())
142146
.bench_refs(|ctx| {
@@ -168,6 +172,9 @@ fn retained_probes(bencher: Bencher, nullable: bool) {
168172
);
169173
}
170174

175+
drop(checked_probe);
176+
drop(reference);
177+
drop(check);
171178
bencher
172179
.with_inputs(|| {
173180
let mut ctx = SESSION.create_execution_ctx();
@@ -210,7 +217,9 @@ fn first_probes(bencher: Bencher, missing: bool) {
210217
.vortex_expect("primitive oracle")
211218
);
212219
assert_eq!(actual.is_null(), missing);
220+
drop(actual);
213221

222+
drop(check);
214223
bencher
215224
.with_inputs(|| SESSION.create_execution_ctx())
216225
.bench_refs(|ctx| {

0 commit comments

Comments
 (0)