Skip to content

Commit 80f789b

Browse files
authored
Merge pull request #9 from webfactory/test-symfony-5
Extend matrix to test with Symfony 5.x and Twig 3.x
2 parents 278a8af + 151c256 commit 80f789b

27 files changed

Lines changed: 59 additions & 15 deletions

.github/workflows/dependencies.yml

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
name: Dependencies
2+
3+
permissions:
4+
contents: read
5+
6+
on:
7+
push:
8+
branches:
9+
- master
10+
pull_request:
11+
12+
env:
13+
PHP_VERSION: 7.2
14+
15+
jobs:
16+
composer-require-checker:
17+
name: Check missing composer requirements
18+
runs-on: ubuntu-20.04
19+
steps:
20+
- uses: shivammathur/setup-php@v2
21+
with:
22+
php-version: ${{ env.PHP_VERSION }}
23+
tools: composer:v2
24+
- uses: actions/checkout@v2
25+
- uses: actions/cache@v2
26+
with:
27+
path: vendor
28+
key: composer-${{ runner.os }}-${{ env.PHP_VERSION }}-${{ matrix.symfony-locked-version }}-${{ matrix.dependency-version }}-${{ hashFiles('composer.json') }}
29+
restore-keys: |
30+
composer-${{ runner.os }}-${{ env.PHP_VERSION }}-${{ matrix.symfony-locked-version }}-${{ matrix.dependency-version }}-
31+
- run: composer install --no-interaction --no-scripts --no-progress --prefer-dist
32+
- uses: docker://webfactory/composer-require-checker:3.2.0

.github/workflows/tests.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,13 @@ env:
1313
jobs:
1414
PHPUnit:
1515

16-
runs-on: ubuntu-20.04
16+
runs-on: ubuntu-18.04
1717
strategy:
1818
fail-fast: false
1919
matrix:
2020
include:
2121
- { symfony-locked-version: none, dependency-version: prefer-lowest }
22+
- { symfony-locked-version: none, dependency-version: prefer-stable }
2223
- { symfony-locked-version: 3.4.*, dependency-version: prefer-stable }
2324
- { symfony-locked-version: 4.4.*, dependency-version: prefer-stable }
2425
name: PHPUnit (Symfony Version Lock ${{ matrix.symfony-locked-version }}, ${{ matrix.dependency-version }})
@@ -31,13 +32,13 @@ jobs:
3132
- uses: actions/cache@v2
3233
with:
3334
path: vendor
34-
key: composer-${{ runner.os }}-${{ env.PHP_VERSION }}-${{ matrix.symfony-locked-version }}-${{ matrix.dependency-version }}-${{ hashFiles('composer.json', 'composer.lock') }}
35+
key: composer-${{ runner.os }}-${{ env.PHP_VERSION }}-${{ matrix.symfony-locked-version }}-${{ matrix.dependency-version }}-${{ hashFiles('composer.json') }}
3536
restore-keys: |
3637
composer-${{ runner.os }}-${{ env.PHP_VERSION }}-${{ matrix.symfony-locked-version }}-${{ matrix.dependency-version }}-
37-
composer-${{ runner.os }}-${{ env.PHP_VERSION }}-
38-
composer-${{ runner.os }}-
3938
- run: VERSION=${{ matrix.symfony-locked-version }} .github/workflows/lock-symfony-version.sh
4039
if: matrix.symfony-locked-version != 'none'
4140
- run: composer update --${{ matrix.dependency-version }} --no-interaction --no-scripts --no-progress --prefer-dist
4241
- run: composer show
4342
- run: vendor/bin/phpunit
43+
- uses: lhotari/action-upterm@v1
44+
if: failure()

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ vendor/
33
phpunit.xml
44
.phpunit.result.cache
55
.php_cs.cache
6-
Tests/Fixtures/cache/
6+
tests/Fixtures/cache/

Tests/Fixtures/cache/.keepme

Whitespace-only changes.

composer.json

Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,29 +5,40 @@
55

66
"require": {
77
"php": ">=7.2",
8+
"ext-json": "*",
9+
"ext-mbstring": "*",
810
"psr/log": "^1.0.2",
9-
"symfony/dependency-injection": "^3.4.11|^4.0",
10-
"symfony/http-kernel": "^3.4.11|^4.0",
11-
"symfony/twig-bundle": "^3.4.11|^4.0",
11+
"symfony/config": "^3.4.11|^4.0|^5.0",
12+
"symfony/dependency-injection": "^3.4.11|^4.0|^5.0",
13+
"symfony/http-foundation": "^3.4.11|^4.0|^5.0",
14+
"symfony/http-kernel": "^3.4.11|^4.0|^5.0",
1215
"thunderer/shortcode": "^0.6.5|^0.7",
13-
"twig/twig": "^1.34|^2.0"
16+
"twig/twig": "^1.34|^2.0|^3.0"
1417
},
1518

1619
"require-dev": {
17-
"phpunit/phpunit": "^7.0|^8.0",
18-
"symfony/expression-language": "^3.4.11|^4.0",
19-
"symfony/framework-bundle": "^3.4.11|^4.0",
20+
"phpunit/phpunit": "^7.0|^8.0|^9.0",
21+
"symfony/expression-language": "^3.4.11|^4.0|^5.0",
22+
"symfony/framework-bundle": "^3.4.11|^4.0|^5.0",
2023
"symfony/phpunit-bridge": "*",
21-
"symfony/templating": "^3.4.11|^4.0",
22-
"symfony/yaml": "^3.4.11|^4.0"
24+
"symfony/routing": "^3.4.11|^4.0|^5.0",
25+
"symfony/templating": "^3.4.11|^4.0|^5.0",
26+
"symfony/twig-bundle": "^3.4.11|^4.0|^5.0",
27+
"symfony/yaml": "^3.4.11|^4.0|^5.0"
2328
},
2429

2530
"autoload": {
2631
"psr-4": {
27-
"Webfactory\\ShortcodeBundle\\": ""
32+
"Webfactory\\ShortcodeBundle\\": "src"
2833
}
2934
},
3035

36+
"autoload-dev": {
37+
"psr-4": {
38+
"Webfactory\\ShortcodeBundle\\Tests\\": "tests"
39+
}
40+
},
41+
3142
"config": {
3243
"sort-packages": true
3344
}

DependencyInjection/Compiler/ShortcodeCompilerPass.php renamed to src/DependencyInjection/Compiler/ShortcodeCompilerPass.php

File renamed without changes.

DependencyInjection/WebfactoryShortcodeExtension.php renamed to src/DependencyInjection/WebfactoryShortcodeExtension.php

File renamed without changes.

0 commit comments

Comments
 (0)