Add support for python 3.8 (#24)

* feat: add support for python 3.8

* add poetry.lock

* fix: convert builtins to typing.Dict

Author: furqaankhan

.github/workflows/pypi-publish.yaml

@@ -17,7 +17,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-python@v4
         with:
-          python-version: 3.9
+          python-version: 3.8
       - name: Install Poetry
         uses: snok/install-poetry@v1
       - name: Compare tag and project version

poetry.lock

@@ -12,13 +12,13 @@ Homepage = "https://github.com/wherobots/wherobots-python-dbapi-driver"
 Tracker = "https://github.com/wherobots/wherobots-python-dbapi-driver/issues"
 
 [tool.poetry.dependencies]
-python = "^3.9"
+python = "^3.8"
 requests = "^2.31.0"
 websockets = "13.0"
 tenacity = "^8.2.3"
 pyarrow = "^14.0.2"
 cbor2 = "^5.6.3"
-pandas = "^2.1.0"
+pandas = "^2.0"
 StrEnum = "^0.4.15"
 # pyarrow 14.0.2 doesn't limit numpy < 2, but it should, we do it here
 numpy = "<2"
@@ -27,7 +27,7 @@ numpy = "<2"
 mypy = "^1.8.0"
 pytest = "^8.0.2"
 black = "^24.2.0"
-pre-commit = "^3.6.2"
+pre-commit = ">=3.5, <3.8.0"
 conventional-pre-commit = "^3.1.0"
 types-requests = "^2.32.0.20241016"
 rich = "^13.7.1"

pyproject.toml

@@ -4,7 +4,7 @@
 import threading
 import uuid
 from dataclasses import dataclass
-from typing import Any, Callable, Union
+from typing import Any, Callable, Union, Dict
 
 import cbor2
 import pandas
@@ -163,7 +163,7 @@ def __listen(self) -> None:
         else:
             logging.warning("Received unknown %s event!", kind)
 
-    def _handle_results(self, execution_id: str, results: dict[str, Any]) -> Any:
+    def _handle_results(self, execution_id: str, results: Dict[str, Any]) -> Any:
         result_bytes = results.get("result_bytes")
         result_format = results.get("format")
         result_compression = results.get("compression")
@@ -185,12 +185,12 @@ def _handle_results(self, execution_id: str, results: dict[str, Any]) -> Any:
         else:
             return OperationalError(f"Unsupported results format {result_format}")
 
-    def __send(self, message: dict[str, Any]) -> None:
+    def __send(self, message: Dict[str, Any]) -> None:
         request = json.dumps(message)
         logging.debug("Request: %s", request)
         self.__ws.send(request)
 
-    def __recv(self) -> dict[str, Any]:
+    def __recv(self) -> Dict[str, Any]:
         frame = self.__ws.recv(timeout=self.__read_timeout)
         if isinstance(frame, str):
             message = json.loads(frame)

wherobots/db/connection.py

@@ -1,5 +1,5 @@
 import queue
-from typing import Any, Optional, List, Tuple
+from typing import Any, Optional, List, Tuple, Dict
 
 from .errors import DatabaseError, ProgrammingError
 
@@ -72,7 +72,7 @@ def __get_results(self) -> Optional[List[Tuple[Any, ...]]]:
 
         return self.__results
 
-    def execute(self, operation: str, parameters: dict[str, Any] = None) -> None:
+    def execute(self, operation: str, parameters: Dict[str, Any] = None) -> None:
         if self.__current_execution_id:
             self.__cancel_fn(self.__current_execution_id)
 
@@ -85,7 +85,7 @@ def execute(self, operation: str, parameters: dict[str, Any] = None) -> None:
         self.__current_execution_id = self.__exec_fn(sql, self.__on_execution_result)
 
     def executemany(
-        self, operation: str, seq_of_parameters: list[dict[str, Any]]
+        self, operation: str, seq_of_parameters: List[Dict[str, Any]]
     ) -> None:
         raise NotImplementedError
 
@@ -96,13 +96,13 @@ def fetchone(self) -> Any:
         self.__current_row += 1
         return results[0]
 
-    def fetchmany(self, size: int = None) -> list[Any]:
+    def fetchmany(self, size: int = None) -> List[Any]:
         size = size or self.arraysize
         results = self.__get_results()[self.__current_row : self.__current_row + size]
         self.__current_row += size
         return results
 
-    def fetchall(self) -> list[Any]:
+    def fetchall(self) -> List[Any]:
         return self.__get_results()[self.__current_row :]
 
     def close(self) -> None:

wherobots/db/cursor.py

@@ -2,7 +2,7 @@
 
 A PEP-0249 compatible driver for interfacing with Wherobots DB.
 """
-
+import ssl
 from importlib import metadata
 from importlib.metadata import PackageNotFoundError
 import logging
@@ -11,9 +11,10 @@
 import queue
 import requests
 import tenacity
-from typing import Union
+from typing import Union, Dict
 import urllib.parse
 import websockets.sync.client
+import certifi
 
 from .connection import Connection
 from .constants import (
@@ -163,7 +164,7 @@ def http_to_ws(uri: str) -> str:
 def connect_direct(
     uri: str,
     protocol: Version = PROTOCOL_VERSION,
-    headers: dict[str, str] = None,
+    headers: Dict[str, str] = None,
     read_timeout: float = DEFAULT_READ_TIMEOUT_SECONDS,
     results_format: Union[ResultsFormat, None] = None,
     data_compression: Union[DataCompression, None] = None,
@@ -174,10 +175,13 @@ def connect_direct(
 
     try:
         logging.info("Connecting to SQL session at %s ...", uri_with_protocol)
+        ssl_context = ssl.create_default_context()
+        ssl_context.load_verify_locations(certifi.where())
         ws = websockets.sync.client.connect(
             uri=uri_with_protocol,
             additional_headers=headers,
             max_size=MAX_MESSAGE_SIZE,
+            ssl=ssl_context,
         )
     except Exception as e:
         raise InterfaceError("Failed to connect to SQL session!") from e