Make Differs and Patchers package public

[Benestar]

To be able to use those components outside of this package for other entity differs they must be package public. I wonder what would be a nice namespace name...

[thiemowmde]

Please collect a list of the specific classes that should become public. Do we really need all of them? Is there an other way?

[Benestar]

We could also create interfaces and offer a factory but that seems to be an unnecessary overhead.

The classes needed for a MediaInfoDiffer and MediaInfoPatcher are (afaik) StatementListDiffer, StatementListPatcher and when merged TermListPatcher.

[JeroenDeDauw]

I wonder what would be a nice namespace name...

Something wrong with the one they are currently in? It already has differs, patchers and diffs in it.

[Benestar]

I rather referred to \Internal which suggests that the classes are package private.

[JeroenDeDauw]

Yeah I get that. So if they are no longer package private, they go out of the Internal sub-NS, which leaves the in the Diff NS. Anything wrong with that NS? (That was my question)

[Benestar]

Ah, sorry. Nothing wrong with that namespace besides it gets a bit crowded. But that's perhaps not a problem yet.

[Benestar]

Btw, do we only want to move the classes listed above out of the Internal namespace or move everything out of it? It might not be obvious why TermListPatcher is public while AliasGroupListPatcher is private.

[JeroenDeDauw]

To me it seems strange to just move some of them out of these, if they are all doing equivalent things.