No need to overdo WP_CLI_TEST_SHELL_COLUMNS_RESET check.

gitlost · gitlost · commit 8471ed138d83 · 2017-06-05T20:28:25.000+01:00
diff --git a/lib/cli/Shell.php b/lib/cli/Shell.php
@@ -27,7 +27,7 @@ class Shell {
 	static public function columns() {
 		static $columns;
 
-		if ( false !== ( $env_reset = getenv( 'WP_CLI_TEST_SHELL_COLUMNS_RESET' ) ) && $env_reset ) {
+		if ( getenv( 'WP_CLI_TEST_SHELL_COLUMNS_RESET' ) ) {
 			$columns = null;
 		}
 		if ( null === $columns ) {

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ class Shell {`
`27`	`27`	`static public function columns() {`
`28`	`28`	`static $columns;`
`29`	`29`
`30`		`- if ( false !== ( $env_reset = getenv( 'WP_CLI_TEST_SHELL_COLUMNS_RESET' ) ) && $env_reset ) {`
	`30`	`+ if ( getenv( 'WP_CLI_TEST_SHELL_COLUMNS_RESET' ) ) {`
`31`	`31`	`$columns = null;`
`32`	`32`	`}`
`33`	`33`	`if ( null === $columns ) {`