Writing final fields per reflection is not possible anymore

Author: JohannesRabauer

spring-data-eclipse-store/pom.xml

@@ -298,6 +298,7 @@
 						--add-opens java.base/java.lang=ALL-UNNAMED
 						--add-opens=java.base/java.lang.reflect=ALL-UNNAMED
 						--add-exports java.base/jdk.internal.misc=ALL-UNNAMED
+						-Djdk.reflect.useDirectMethodHandle=false
 					</argLine>
 				</configuration>
 			</plugin>

…ifier/FieldAccessModifierToEditable.java …re/exceptions/IdFieldFinalException.javaspring-data-eclipse-store/src/main/java/software/xdev/spring/data/eclipse/store/repository/access/modifier/FieldAccessModifierToEditable.java renamed to spring-data-eclipse-store/src/main/java/software/xdev/spring/data/eclipse/store/exceptions/IdFieldFinalException.java spring-data-eclipse-store/src/main/java/software/xdev/spring/data/eclipse/store/repository/access/modifier/FieldAccessModifierToEditable.java renamed to spring-data-eclipse-store/src/main/java/software/xdev/spring/data/eclipse/store/exceptions/IdFieldFinalException.java

@@ -13,12 +13,12 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package software.xdev.spring.data.eclipse.store.repository.access.modifier;
+package software.xdev.spring.data.eclipse.store.exceptions;
 
-/**
- * Provides a way to open member variables (fields) to changes.
- */
-public interface FieldAccessModifierToEditable<E> extends FieldAccessModifier<E>
+public class IdFieldFinalException extends RuntimeException
 {
-	void writeValueOfField(E objectOfFieldToWriteTo, Object valueToWrite) throws IllegalAccessException;
+	public IdFieldFinalException(final String message)
+	{
+		super(message);
+	}
 }

spring-data-eclipse-store/src/main/java/software/xdev/spring/data/eclipse/store/exceptions/MergeFailedException.java

@@ -21,9 +21,9 @@ public MergeFailedException(final Object sourceObject, final Object targetObject
 	{
 		super(
 			String.format(
-				"Could not merge values of object %s with object %s",
-				sourceObject.toString(),
-				targetObject.toString()
+				"Could not merge values of object %s# with object %s",
+				sourceObject.getClass().getName(),
+				targetObject.getClass().getName()
 			),
 			e
 		);

spring-data-eclipse-store/src/main/java/software/xdev/spring/data/eclipse/store/repository/EclipseStoreStorage.java

@@ -43,14 +43,14 @@
 
 
 @Component
-public class EclipseStoreStorage implements EntityListProvider, IdSetterProvider, PersistableChecker
+public class EclipseStoreStorage
+	implements EntityListProvider, IdSetterProvider, PersistableChecker
 {
 	private static final Logger LOG = LoggerFactory.getLogger(EclipseStoreStorage.class);
 	private final Map<Class<?>, String> entityClassToRepositoryName = new HashMap<>();
 	private final Map<Class<?>, IdSetter<?>> entityClassToIdSetter = new HashMap<>();
 	private EntitySetCollector entitySetCollector;
 	private PersistableChecker persistenceChecker;
-	
 	private final EclipseStoreProperties storeConfiguration;
 	private final EclipseStoreProvider storeProvider;
 

spring-data-eclipse-store/src/main/java/software/xdev/spring/data/eclipse/store/repository/access/modifier/FieldAccessModifier.java

@@ -16,60 +16,21 @@
 package software.xdev.spring.data.eclipse.store.repository.access.modifier;
 
 import java.lang.reflect.Field;
-import java.lang.reflect.InvocationTargetException;
 import java.util.Objects;
-import java.util.concurrent.atomic.AtomicInteger;
 
 
 /**
  * Provides a way to open member variables (fields) to changes.
  */
 public interface FieldAccessModifier<E> extends AutoCloseable
 {
-	AtomicInteger javaVersion = new AtomicInteger(0);
-	
-	static <T> FieldAccessModifierToEditable<T> makeFieldEditable(final Field field, final T sourceObject)
-		throws InvocationTargetException, IllegalAccessException
-	{
-		if(javaVersion.get() == 0)
-		{
-			javaVersion.set(getJavaVersion());
-		}
-		if(javaVersion.get() < 18)
-		{
-			return new FieldEditableMakerForJavaLowerThan18<>(
-				Objects.requireNonNull(field),
-				Objects.requireNonNull(sourceObject)
-			);
-		}
-		return new FieldEditableMakerForJavaHigherOrEqualTo18<>(
-			Objects.requireNonNull(field),
-			Objects.requireNonNull(sourceObject)
-		);
-	}
-	
 	static <T> FieldAccessModifier<T> makeFieldReadable(final Field field, final T sourceObject)
 	{
 		return new FieldAccessibleMaker<>(Objects.requireNonNull(field), Objects.requireNonNull(sourceObject));
 	}
 
 	Object getValueOfField(E objectOfFieldToRead) throws IllegalAccessException;
 
-	private static int getJavaVersion()
-	{
-		String version = System.getProperty("java.version");
-		if(version.startsWith("1."))
-		{
-			version = version.substring(2, 3);
-		}
-		else
-		{
-			final int dot = version.indexOf(".");
-			if(dot != -1)
-			{
-				version = version.substring(0, dot);
-			}
-		}
-		return Integer.parseInt(version);
-	}
+	void writeValueOfField(E objectOfFieldToWriteTo, Object valueToWrite, boolean throwExceptionIfFinal)
+		throws IllegalAccessException;
 }

spring-data-eclipse-store/src/main/java/software/xdev/spring/data/eclipse/store/repository/access/modifier/FieldAccessibleMaker.java

@@ -16,6 +16,8 @@
 package software.xdev.spring.data.eclipse.store.repository.access.modifier;
 
 import java.lang.reflect.Field;
+import java.lang.reflect.Modifier;
+import java.util.Objects;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -36,11 +38,14 @@ public class FieldAccessibleMaker<E> implements FieldAccessModifier<E>
 	private static final Logger LOG = LoggerFactory.getLogger(FieldAccessibleMaker.class);
 	private final Field field;
 	private final boolean wasAccessible;
+	private final boolean isFinal;
 
 	FieldAccessibleMaker(final Field field, final E sourceObject)
 	{
 		this.field = field;
-		this.wasAccessible = field.canAccess(sourceObject);
+		this.wasAccessible = field.canAccess(Objects.requireNonNull(sourceObject));
+		final int fieldModifiers = field.getModifiers();
+		this.isFinal = Modifier.isFinal(fieldModifiers);
 		if(!this.wasAccessible)
 		{
 			if(LOG.isTraceEnabled())
@@ -60,6 +65,27 @@ public Object getValueOfField(final E objectOfFieldToRead) throws IllegalAccessE
 		return this.field.get(objectOfFieldToRead);
 	}
 
+	@Override
+	public void writeValueOfField(
+		final E objectOfFieldToWriteTo,
+		final Object valueToWrite,
+		final boolean throwExceptionIfFinal)
+		throws IllegalAccessException
+	{
+		if(throwExceptionIfFinal && this.isFinal)
+		{
+			throw new IllegalAccessException(String.format(
+				"Field %s:%s is final and cannot be modified. Make the field not final.",
+				objectOfFieldToWriteTo.toString(), this.field.getName()));
+		}
+		this.field.set(objectOfFieldToWriteTo, valueToWrite);
+	}
+	
+	public boolean isFinal()
+	{
+		return this.isFinal;
+	}
+	
 	@Override
 	public void close()
 	{