Merge remote-tracking branch 'origin/update-from-template' into develop

Author: AB-xdev

.config/checkstyle/checkstyle.xml

@@ -74,6 +74,11 @@
 			<!-- https://docs.pmd-code.org/pmd-doc-7.11.0/pmd_rules_java_errorprone.html#avoidcatchingthrowable -->
 			<property name="illegalClassNames" value="Error,Throwable,NullPointerException,java.lang.Error,java.lang.Throwable,java.lang.NullPointerException"/>
 		</module>
+		<!-- Do not allow params and vars to end with collection type names -->
+		<module name="IllegalIdentifierName">
+			<property name="format" value="^(?!(.*(Map|List|Set))$).+$"/>
+			<property name="tokens" value="PARAMETER_DEF, VARIABLE_DEF, PATTERN_VARIABLE_DEF, RECORD_COMPONENT_DEF, LAMBDA"/>
+		</module>
 		<module name="IllegalImport"/>
 		<module name="InterfaceIsType"/>
 		<module name="JavadocStyle">
@@ -122,7 +127,10 @@
 		<module name="StaticVariableName"/>
 		<module name="StringLiteralEquality"/>
 		<module name="SuppressWarningsHolder"/>
-		<module name="TodoComment"/>
+		<module name="TodoComment">
+			<!-- Default is "TODO:" -->
+			<property name="format" value="(?i)(TODO)"/>
+		</module>
 		<module name="TypecastParenPad"/>
 		<module name="TypeName"/>
 		<module name="UnnecessaryParentheses"/>

.config/pmd/java/ruleset.xml

@@ -394,6 +394,30 @@ If you are 100% sure that you escaped the value properly and you have no better
 		</properties>
 	</rule>
 
+	<!-- Jakarta Persistence -->
+	<rule name="AvoidListAsEntityRelation"
+		language="java"
+		message="Use a Set instead of a List in entity relations"
+		class="net.sourceforge.pmd.lang.rule.xpath.XPathRule"
+		externalInfoUrl="https://www.baeldung.com/spring-jpa-onetomany-list-vs-set#bd-pros-and-cons">
+		<description>
+`List` allows duplicates while a `Set` does not.
+A `Set` also prevents duplicates when the ORM reads multiple identical rows from the database (e.g. when using JOIN).
+		</description>
+		<priority>2</priority>
+		<properties>
+			<property name="xpath">
+				<value>
+<![CDATA[
+//ClassDeclaration[pmd-java:hasAnnotation('jakarta.persistence.Entity')]
+//FieldDeclaration[pmd-java:hasAnnotation('jakarta.persistence.ManyToMany') or pmd-java:hasAnnotation('jakarta.persistence.OneToMany')]
+/ClassType[pmd-java:typeIs('java.util.List')]
+]]>
+				</value>
+			</property>
+		</properties>
+	</rule>
+
 
 	<!-- Rules from JPinPoint with slight modifications -->
 	<!-- https://github.com/jborgers/PMD-jPinpoint-rules -->

.github/workflows/check-build.yml

@@ -81,7 +81,7 @@ jobs:
     timeout-minutes: 15
     strategy:
       matrix:
-        java: [ 21 ]
+        java: [21]
         distribution: [temurin]
     steps:
     - uses: actions/checkout@v6