Skip to content

Commit f7b75f2

Browse files
Fix checkstyle
Co-Authored-By: Johannes Rabauer <8188460+JohannesRabauer@users.noreply.github.com>
1 parent f172f3c commit f7b75f2

29 files changed

Lines changed: 116 additions & 135 deletions

File tree

spring-data-eclipse-store-demo/src/main/java/software/xdev/spring/data/eclipse/store/demo/complex/ComplexDemoApplication.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package software.xdev.spring.data.eclipse.store.demo.complex;
1818

1919
import java.time.LocalDate;
20-
import java.time.temporal.ChronoUnit;
2120

2221
import org.slf4j.Logger;
2322
import org.slf4j.LoggerFactory;
@@ -125,13 +124,14 @@ private static Vet createVet()
125124
return vet;
126125
}
127126

127+
@SuppressWarnings("checkstyle:MagicNumber")
128128
private static Owner createOwner()
129129
{
130130
final Owner owner = new Owner();
131131
owner.setFirstName("Stevie");
132132
owner.setLastName("Nicks");
133133
final Pet pet = new Pet();
134-
pet.setBirthDate(LocalDate.now().minus(6, ChronoUnit.WEEKS));
134+
pet.setBirthDate(LocalDate.now().minusWeeks(6));
135135
pet.setName("Peter");
136136
final PetType petType = new PetType();
137137
petType.setName("Dog");

spring-data-eclipse-store-demo/src/main/java/software/xdev/spring/data/eclipse/store/demo/complex/model/BaseEntity.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@
1717

1818
import java.io.Serializable;
1919

20-
import org.springframework.data.annotation.Id;
21-
2220
import jakarta.persistence.GeneratedValue;
2321
import jakarta.persistence.GenerationType;
2422

23+
import org.springframework.data.annotation.Id;
24+
2525

2626
public class BaseEntity implements Serializable
2727
{
@@ -42,8 +42,8 @@ public boolean isNew()
4242
@Override
4343
public String toString()
4444
{
45-
return "BaseEntity{" +
46-
"id=" + this.id +
47-
'}';
45+
return "BaseEntity{"
46+
+ "id=" + this.id
47+
+ '}';
4848
}
4949
}

spring-data-eclipse-store-demo/src/main/java/software/xdev/spring/data/eclipse/store/demo/complex/model/Person.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ public void setLastName(final String lastName)
4444
@Override
4545
public String toString()
4646
{
47-
return "Person{" +
48-
"firstName='" + this.firstName + '\'' +
49-
", lastName='" + this.lastName + '\'' +
50-
'}';
47+
return "Person{"
48+
+ "firstName='" + this.firstName + '\''
49+
+ ", lastName='" + this.lastName + '\''
50+
+ '}';
5151
}
5252
}

spring-data-eclipse-store-demo/src/main/java/software/xdev/spring/data/eclipse/store/demo/simple/Customer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
public class Customer
77
{
88
@Id
9-
public String id;
9+
private String id;
1010

1111
private final String firstName;
1212
private final String lastName;

spring-data-eclipse-store-demo/src/main/java/software/xdev/spring/data/eclipse/store/demo/simple/Pet.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
public class Pet
77
{
88
@Id
9-
public String id;
9+
private String id;
1010

1111
private String name;
1212
private Integer age;

spring-data-eclipse-store/src/main/java/software/xdev/spring/data/eclipse/store/repository/EclipseStoreStorage.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@
2323
import java.util.function.Consumer;
2424
import java.util.function.Supplier;
2525

26+
import jakarta.inject.Inject;
27+
import jakarta.inject.Named;
28+
2629
import org.eclipse.serializer.persistence.types.Storer;
2730
import org.eclipse.store.integrations.spring.boot.types.EclipseStoreProvider;
2831
import org.eclipse.store.integrations.spring.boot.types.configuration.EclipseStoreProperties;
@@ -32,8 +35,6 @@
3235
import org.slf4j.LoggerFactory;
3336
import org.springframework.stereotype.Component;
3437

35-
import jakarta.inject.Inject;
36-
import jakarta.inject.Named;
3738
import software.xdev.spring.data.eclipse.store.core.IdentitySet;
3839
import software.xdev.spring.data.eclipse.store.exceptions.AlreadyRegisteredException;
3940
import software.xdev.spring.data.eclipse.store.repository.support.copier.id.IdSetter;
@@ -54,7 +55,7 @@ public class EclipseStoreStorage implements EntityListProvider, IdSetterProvider
5455
private final EclipseStoreProvider storeProvider;
5556

5657
private StorageManager storageManager;
57-
private Root root = null;
58+
private Root root;
5859

5960
private final WorkingCopyRegistry registry = new WorkingCopyRegistry();
6061
private RepositorySynchronizer repositorySynchronizer;

spring-data-eclipse-store/src/main/java/software/xdev/spring/data/eclipse/store/repository/EntitySetCollector.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,9 @@ public class EntitySetCollector
3131
private static final Logger LOG = LoggerFactory.getLogger(EntitySetCollector.class);
3232
private final Map<Class<?>, List<IdentitySet<? super Object>>> childClassToParentSets = new HashMap<>();
3333

34-
public EntitySetCollector
35-
(
36-
final Map<String, IdentitySet<Object>> entityLists,
37-
final Map<Class<?>, String> entityClassToRepositoryName
38-
)
34+
public EntitySetCollector(
35+
final Map<String, IdentitySet<Object>> entityLists,
36+
final Map<Class<?>, String> entityClassToRepositoryName)
3937
{
4038
this.buildParentClassList(entityLists, entityClassToRepositoryName);
4139
}

spring-data-eclipse-store/src/main/java/software/xdev/spring/data/eclipse/store/repository/access/AccessHelper.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,12 @@
3131
/**
3232
* Helps finding and handling {@link Field}s.
3333
*/
34-
public class AccessHelper
34+
public final class AccessHelper
3535
{
3636
private static final Logger LOG = LoggerFactory.getLogger(AccessHelper.class);
3737

3838
private AccessHelper()
3939
{
40-
// Only static methods
4140
}
4241

4342
/**

spring-data-eclipse-store/src/main/java/software/xdev/spring/data/eclipse/store/repository/query/criteria/AbstractCriteriaNode.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,8 @@ public AbstractCriteriaNode<T> between(final Object minValue, final Object maxVa
111111
Objects.requireNonNull(maxValue);
112112
this.predicates.add(entity -> {
113113
final Object value = Objects.requireNonNull(this.field).readValue(entity);
114-
return GenericObjectComparer.isLessOrEqualTo(value, maxValue) &&
115-
GenericObjectComparer.isGreaterOrEqualTo(value, minValue);
114+
return GenericObjectComparer.isLessOrEqualTo(value, maxValue)
115+
&& GenericObjectComparer.isGreaterOrEqualTo(value, minValue);
116116
});
117117
return this;
118118
}

spring-data-eclipse-store/src/main/java/software/xdev/spring/data/eclipse/store/repository/query/executors/EntitySorter.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,13 @@
2626
import software.xdev.spring.data.eclipse.store.util.GenericObjectComparer;
2727

2828

29-
public class EntitySorter
29+
public final class EntitySorter
3030
{
3131
private EntitySorter()
3232
{
33-
// Only static methods
3433
}
3534

36-
public static <T> Stream<T> sortEntitiesStream(final Class<T> clazz, final Sort sort, Stream<T> entityStream)
35+
public static <T> Stream<T> sortEntitiesStream(final Class<T> clazz, final Sort sort, final Stream<T> entityStream)
3736
{
3837
if(sort != null)
3938
{
@@ -45,7 +44,7 @@ public static <T> Stream<T> sortEntitiesStream(final Class<T> clazz, final Sort
4544
AccessHelper.getInheritedPrivateField(clazz, order.getProperty());
4645
final Comparator<? super T> comparator =
4746
EntitySorter.getComparator(fieldForOrder, order.getDirection());
48-
entityStream = entityStream.sorted(comparator);
47+
return entityStream.sorted(comparator);
4948
}
5049
catch(final NoSuchFieldException e)
5150
{

0 commit comments

Comments
 (0)