ci: gate build step on changeset-release PRs; rewrite RELEASING for changesets - #133
Merged
Conversation
…hangesets The inline build step in ci-trigger.yml ran on changeset-release/* PRs where the shared ci action skips pnpm setup, failing with "pnpm: command not found". Gate it with the same head_ref guard the shared action uses. Also rewrite docs/RELEASING.md: it still described the old Lerna manual-dispatch flow. Document the actual changesets cycle (version PR -> merge -> OIDC publish), snapshot prereleases, and that changesets (not commit messages) drive versions.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes from the first release on the new Changesets pipeline.
1. CI false-red on version PRs
The shared
0xPolygon/pipelines/.github/actions/ciaction gates every step (including pnpm setup) withif: "!startsWith(github.head_ref, 'changeset-release/')", because those branches carry only version/changelog changes. The inlinebuildstep we add inci-trigger.ymlwas not gated, so on thechangeset-release/mainPR it ran with no pnpm on PATH and failed withpnpm: command not found(exit 127). This showed the version PR as red even though nothing was wrong.Fix: gate the build step with the same
head_refguard, so it skips onchangeset-release/*(nothing to build there) and runs normally on real PRs.2. RELEASING.md described the retired Lerna flow
docs/RELEASING.mdstill documented the old "Actions → Run workflow → pick a channel" Lerna dispatch and conventional-commit-driven versioning. Rewritten to describe the actual Changesets cycle:pnpm changeset); the bump level comes from the changeset, not commit messagesmain→ Release workflow opens the Version Packages PR → merge that → OIDC publish + git tags + GitHub Releaseworkflow_dispatch(non-semver dist-tag)Docs + CI only; no package source changes.