fix(connect): make Google WaaS sign-in directly interactive#606
Open
AlexanderKolberg wants to merge 5 commits into
Open
fix(connect): make Google WaaS sign-in directly interactive#606AlexanderKolberg wants to merge 5 commits into
AlexanderKolberg wants to merge 5 commits into
Conversation
Deploying web-sdk-react-example with
|
| Latest commit: |
a2b740a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8721b539.web-sdk-react-example.pages.dev |
| Branch Preview URL: | https://fix-google-waas-button.web-sdk-react-example.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c255aeb91f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket link:
API breaking changes:
Manual testing required:
Docs changes required:
Description
It looks like Google login broke following Chromium's coordinate-spoofing protection for async hit-testing, affecting users on Android and Windows running Chromium 149 and newer.
The previous implementation placed a nearly transparent Google Identity Services iframe behind a custom button and enlarged it with
transform: scale(100). It also started the connection loader from the parent card's click handler. This depended on fragile cross-origin iframe hit-testing: when the click remained in the parent document, the UI showed “Continue on the popup” even though Google never received the interaction and no popup opened.This PR removes that click-proxying approach and keeps Google's official control visible and directly interactive.
Unfortunately, this makes the Google button look a little less polished than the previous custom facade. Google's cross-origin iframe controls its own typography, logo, and spacing, so matching the previous UI exactly would require returning to the fragile click-proxying approach.
Before
After