fix: refactor login.py for improved readability and logging enhancements - #6549
Merged
Conversation
Contributor
Author
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
There was a problem hiding this comment.
Pull request overview
This PR refactors apps/users/views/login.py with formatting changes and adds extra runtime logging in the login endpoint.
Changes:
- Reformatted the module docstring, imports, and DRF
extend_schema/@logdecorators for readability. - Added an additional logger call in
LoginView.post()to record scheme/HTTPS-related request metadata. - Compressed
_get_details()into a single-line return structure (and altered quoting/style).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3
to
+7
| @project: MaxKB | ||
| @Author：虎虎 | ||
| @file： user.py | ||
| @date：2025/4/14 10:22 | ||
| @desc: |
Comment on lines
+53
to
+57
| from common.utils.logger import maxkb_logger | ||
|
|
||
| maxkb_logger.info( | ||
| f"LoginView.post: request.scheme={request.scheme}, request.is_secure()={request.is_secure()}, request.META['wsgi.url_scheme']={request.META.get('wsgi.url_scheme')}, request.META['HTTPS']={request.META.get('HTTPS')}" | ||
| ) |
Comment on lines
26
to
+30
| def _get_details(request): | ||
| path = request.path | ||
| body = request.data | ||
| query = request.query_params | ||
| return { | ||
| 'path': path, | ||
| 'body': {**body, 'password': encryption(body.get('password', ''))}, | ||
| 'query': query | ||
| } | ||
| return {"path": path, "body": {**body, "password": encryption(body.get("password", ""))}, "query": query} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: refactor login.py for improved readability and logging enhancements