Repository navigation
feat: chat theme #7723
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /** 管理 Chat 入口的智能体主题色，并按需应用到当前文档。 */ | ||
|
|
||
| import { defineStore } from 'pinia' | ||
| import { DEFAULT_THEME_COLOR } from '@/constants' | ||
|
|
||
| export const useChatThemeStore = defineStore('chat-theme', { | ||
| state: () => ({ themeColor: DEFAULT_THEME_COLOR }), | ||
|
|
||
| actions: { | ||
| /** 配置缺失或非法时使用默认色；主题只保存在内存中。 */ | ||
| setTheme(themeColor?: string) { | ||
| const normalizedColor = themeColor?.trim().toLowerCase() | ||
| this.themeColor = normalizedColor && /^#[\da-f]{6}$/.test(normalizedColor) ? normalizedColor : DEFAULT_THEME_COLOR | ||
|
|
||
| const rootStyle = document.documentElement.style | ||
| const hexColor = this.themeColor.slice(1) | ||
| const rgbChannels = [0, 2, 4].map((index) => Number.parseInt(hexColor.slice(index, index + 2), 16)).join(' ') | ||
| rootStyle.setProperty('--mk-primary', this.themeColor) | ||
| rootStyle.setProperty('--mk-primary-rgb', rgbChannels) | ||
| if (this.themeColor === DEFAULT_THEME_COLOR) { | ||
| rootStyle.removeProperty('--mk-primary-gradient') | ||
| rootStyle.removeProperty('--mk-primary-gradient-end') | ||
| } else { | ||
| rootStyle.setProperty('--mk-primary-gradient', this.themeColor) | ||
| rootStyle.setProperty('--mk-primary-gradient-end', this.themeColor) | ||
| } | ||
| }, | ||
|
|
||
| /** 恢复默认主题色与默认蓝紫渐变。 */ | ||
| resetTheme() { | ||
| this.setTheme() | ||
| }, | ||
| }, | ||
| }) | ||
|
Contributor
Author
There was a problem hiding this comment. Overall, the code is functionally reasonable, but there are a few edge cases and architectural concerns worth addressing. Potential issues
Optimization suggestions
Example refactor sketchconst HEX_COLOR_RE = /^#[0-9a-f]{6}$/
const DEFAULT_COLOR = DEFAULT_THEME_COLOR.toLowerCase()
function normalizeColor(color?: string): string {
const normalized = color?.trim().toLowerCase()
return normalized && HEX_COLOR_RE.test(normalized) ? normalized : DEFAULT_COLOR
}
function hexToRgbChannels(hex: string): string {
const value = hex.slice(1)
const r = Number.parseInt(value.slice(0, 2), 16)
const g = Number.parseInt(value.slice(2, 4), 16)
const b = Number.parseInt(value.slice(4, 6), 16)
return `${r} ${g} ${b}`
}
export const useChatThemeStore = defineStore('chat-theme', {
state: () => ({ themeColor: DEFAULT_COLOR }),
actions: {
setTheme(themeColor?: string) {
const color = normalizeColor(themeColor)
this.themeColor = color
if (typeof document === 'undefined') return
const rootStyle = document.documentElement.style
rootStyle.setProperty('--mk-primary', color)
rootStyle.setProperty('--mk-primary-rgb', hexToRgbChannels(color))
if (color === DEFAULT_COLOR) {
rootStyle.removeProperty('--mk-primary-gradient')
rootStyle.removeProperty('--mk-primary-gradient-end')
} else {
rootStyle.setProperty('--mk-primary-gradient', color)
rootStyle.setProperty('--mk-primary-gradient-end', color)
}
},
resetTheme() {
this.setTheme(DEFAULT_COLOR)
},
},
})No major functional bug is present if |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the diff is mostly formatting/import-style cleanup and does not change the main logic. However, there are a few points worth checking:
Potential issues
border-N300was removedborder-N300was a valid design token, this is a visual regression: the border color will change to the default/inherited color.border-N300was invalid or no longer used, this is fine, but prefer using a valid token such asborder-neutral-300or the project’s actual token.border-N300unless the color change is intentional.Long template lines may conflict with the formatter/linter
vue/max-attributes-per-line, this may fail formatting/lint checks.Duplicate readonly condition
is_submitandviewTypeare refs:Then:
Duplicate
editorIdon twoMdPreviewcomponentseditorIdis used as a DOM id or editor instance key, using it twice may cause conflicts.submitshould also guard against readonly/duplicate submissionsubmitis still useful:submitperforms an async request, ensure it cannot be triggered twice while pending. Set a submitting flag beforeawaitand reset it infinally.Minor suggestions
"to'is fine and likely consistent with project style.</script>is harmless.is_submit,form_data, andform_field_listare inconsistent with typical TS/Vue camelCase style, but this is only a style issue if the project enforces it.READONLY_VIEWS.includes(...)is fine for two items. If the list grows significantly, consider aSet<ViewType>:Most important action
Check whether removing
border-N300is intentional. If not, restore it. Then run the project formatter and consider extracting the repeated readonly condition into a computed property.