[shaohuzhang1]

fix: knowledge document strategy permission

[shaohuzhang1]

The diff is syntactically consistent, but there are a few review points:

1. Likely permission bug for workspace-shared resources

   if (isWorkspaceSharedResource()) return false // 共享知识库在工作空间侧只读

   This returns false for both documentStrategyRead and documentStrategyEdit. If the function is ever called with documentStrategyRead, read access is denied, which contradicts the “read-only” comment.
   Suggested fix if read should be allowed:

   if (isWorkspaceSharedResource()) {
     return method === 'documentStrategyRead'
   }

   Or, if only edit is ever used, narrow the type/function to edit-only to avoid misleading semantics.

2. Permission key rename is a breaking change
   The permission methods changed from:

   • knowledgeExternalServiceRead → documentStrategyRead
   • knowledgeExternalServiceEdit → documentStrategyEdit

   Ensure perm.knowledge.system and perm.knowledge.share actually expose these new method names. Otherwise:

   perm.knowledge.system[method]()

   can throw if [method] is undefined. Also check backend permission codes, role configuration, tests, audit logs, and any persisted permissions for migration/backward compatibility.

3. Runtime safety for permission lookup
   Consider guarding the dynamic call:

   return Boolean(perm.knowledge?.system?.[method]?.())

   and similarly for perm.knowledge.share. This avoids crashes if permissions are not loaded yet or a key is missing.

4. Duplicate permission check
   handleSave checks edit permission, and the button also checks it via v-if. This is acceptable, but a computed property would avoid duplication:

   const canEditDocumentStrategy = computed(() =>
     knowledgeDocumentStrategyPermission('documentStrategyEdit')
   )

   Then use it in both places.

5. Minor existing issue
   max-w-200 is not a standard Tailwind utility unless custom-configured. Verify it resolves correctly.

Overall, the rename itself looks internally consistent in the shown diff. The main risks are the workspace-shared read behavior and ensuring the new permission identifiers exist everywhere.