Repository navigation
feat: knowledge document create permission - #7749
Merged
Merged
Conversation
shaohuzhang1
commented
Nov 9, 2026
| v-if="!showQuickCreate && knowledgeDocPermission('docCreate')" | ||
| :api="resourceApi.document" | ||
| :knowledge-id="knowledgeId" | ||
| :knowledge-type="knowledgeType" |
Contributor
Author
There was a problem hiding this comment.
Here is an analysis of the code change:
Irregularities/Issues:
- Naming Convention:
knowledgeDocPermissionlooks like a function call rather than a standard computed property or reactive boolean used in Vue templates. If it is a method, calling it directly inv-ifwill re-execute on every render, which is inefficient for permission checks. - Short-circuit Evaluation: While logically sound,
v-if="!showQuickCreate && knowledgeDocPermission('docCreate')"creates two separate reactive dependency traces. IfshowQuickCreatechanges frequently but permissions do not, Vue still evaluates the expression (though short-circuits). It is generally cleaner to consolidate complex conditional logic into a single computed property.
Optimization Suggestions:
- Use a Computed Property: Move this logic to a
computedblock for better readability, maintainability, and performance caching.Then use it in the template:const canShowImportButton = computed(() => { return !showQuickCreate.value && knowledgeDocPermission('docCreate'); });
<ButtonImportDocument v-if="canShowImportButton" ...> - Verify Function Side Effects: Ensure
knowledgeDocPermissionis a pure function (no side effects) if kept in the template. If it's a method, consider converting it to a computed dependency or ensuring it is sufficiently lightweight.
Summary: The change adds a necessary permission check, but should be refactored into a computed property for best practices in Vue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: knowledge document create permission