Skip to content

fix: [Agent] The settings page contains inaccessible images. #7775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Nov 9, 2026
Merged

fix: [Agent] The settings page contains inaccessible images. #7775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rc/views/application-detail/overview/display-setting/components/DisplaySettingPreview.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,6 @@ const previewHeaderStyle = computed<CSSProperties>(() => ({
</div>
</div>
<!-- 浮窗图标 -->
<img :src="previewImages.float_icon || '/MaxKB.gif'" alt="" class="size-8 shrink-0 object-contain" />
<img :src="previewImages.float_icon || './MaxKB.gif'" alt="" class="size-8 shrink-0 object-contain" />
</div>
</template>

@shaohuzhang1 shaohuzhang1 Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of the diff

Change: /MaxKB.gif → ./MaxKB.gif

Issues / Concerns

  1. Semantic change in path resolution (likely a regression risk)

    • /MaxKB.gif is an absolute path resolved from the site root (e.g., https://host/MaxKB.gif).
    • ./MaxKB.gif is relative to the current route URL, not the app's base. In SPA/Vue Router setups (especially with history mode and nested routes), this can resolve to incorrect URLs such as /some/nested/route/MaxKB.gif, causing 404s.
    • If the intent was "path relative to the deployed app root," use import.meta.env.BASE_URL + 'MaxKB.gif' or a static asset import (import MaxKBIcon from '@/assets/MaxKB.gif').

  2. No leading slash vs. Vite/base-path handling

    • With Vite, public assets are served from BASE_URL. Hardcoding ./ bypasses base-path configuration and will break if the app is deployed under a subpath (e.g., /maxkb/). Prefer: 
      const defaultIcon = `${import.meta.env.BASE_URL}MaxKB.gif`
      then use :src="previewImages.float_icon || defaultIcon".

  3. Hardcoded fallback logic in template

    • Better to move the fallback into a computed property for clarity and testability, e.g.: 
      const floatIconSrc = computed(() => previewImages.value.float_icon || defaultIcon)

  4. Accessibility

    • The <img> uses empty alt="". Since it's a UI icon (not decorative in the strict sense — it likely conveys meaning), consider alt="MaxKB" or mark it role="presentation"/aria-hidden="true" explicitly if truly decorative.

  5. Minor: filename casing

    • MaxKB.gif mixes case; confirm the actual file is capitalized exactly this way on case-sensitive servers (Linux), otherwise it works locally (Windows/macOS) but fails in production.

Recommendation

Revert to /MaxKB.gif or, preferably, switch to a base-URL-aware reference or a bundled asset import to make the path robust across environments.

Loading