Skip to content

fix: [Agent] A simple agent—configured with a "chat history" setting of 2 turns—fails to access prior context; the large language model responds as if the conversation is just beginning ("This is the start of the conversation"). #7799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Nov 10, 2026
Merged

fix: [Agent] A simple agent—configured with a "chat history" setting of 2 turns—fails to access prior context; the large language model responds as if the conversation is just beginning ("This is the start of the conversation"). #7799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/chat/template/agent_simple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,6 +685,7 @@ def build_workflow(application):
knowledge_setting = application.knowledge_setting or {}
no_references_setting = knowledge_setting.get("no_references_setting") or {}
model_setting = application.model_setting or {}
dialogue_number = application.dialogue_number
# 发布版本使用发布时的知识库快照；调试使用 Application 本体，从资源映射读取
if isinstance(application, ApplicationVersion):
knowledge_ids = application.knowledge_ids
Expand Down Expand Up @@ -726,6 +727,7 @@ def build_workflow(application):
data["nodes"][5]["properties"]["node_data"]["mcp_servers"] = application.mcp_servers
data["nodes"][5]["properties"]["node_data"]["application_ids"] = application.application_ids
data["nodes"][5]["properties"]["node_data"]["tool_ids"] = application.tool_ids
data["nodes"][5]["properties"]["node_data"]["dialogue_number"] = application.dialogue_number
## 未查询到知识库ai 回复
data["nodes"][10]["properties"]["node_data"]["model_id"] = model_id
data["nodes"][10]["properties"]["node_data"]["model_params_setting"] = model_params_setting
Expand All @@ -736,6 +738,7 @@ def build_workflow(application):
data["nodes"][10]["properties"]["node_data"]["mcp_servers"] = application.mcp_servers
data["nodes"][10]["properties"]["node_data"]["application_ids"] = application.application_ids
data["nodes"][10]["properties"]["node_data"]["tool_ids"] = application.tool_ids
data["nodes"][10]["properties"]["node_data"]["dialogue_number"] = application.dialogue_number
## 未查询到知识库指定回复
if no_references_setting.get("status") == "designated_answer":
data["nodes"][6]["properties"]["node_data"]["content"] = no_references_setting.get("value")

@shaohuzhang1 shaohuzhang1 Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues / potential problems

  1. Unused local variable

    • dialogue_number = application.dialogue_number is added but never used.
    • Both new assignments still call application.dialogue_number directly: 
      data["nodes"][5]["properties"]["node_data"]["dialogue_number"] = application.dialogue_number
data["nodes"][10]["properties"]["node_data"]["dialogue_number"] = application.dialogue_number
    • Either remove the local variable, or use it consistently: 
      node_data["dialogue_number"] = dialogue_number

  2. Possible AttributeError for legacy / versioned objects

    • application.dialogue_number is accessed three times. If not all Application / ApplicationVersion records have this field, build_workflow can fail.
    • Consider a safe fallback and validation: 
      dialogue_number = getattr(application, "dialogue_number", None)
    • If None is not valid for the workflow schema, define an explicit default or skip assignment.

  3. Published-version snapshot consistency

    • The code comments say published versions use a snapshot. Confirm that dialogue_number is part of the ApplicationVersion snapshot. If it is not versioned, published workflows may use a changing/current value or fail depending on the model.
    • This matters especially because the same function handles both Application and ApplicationVersion.

  4. Workflow schema compatibility

    • Ensure dialogue_number is a supported property for the node_data of nodes 5 and 10.
    • If unsupported, workflow validation or frontend loading may fail, or the field may be silently ignored.
    • Validate the value type, e.g. non-negative integer, and reject/convert invalid strings.

  5. Duplication and hard-coded node indices

    • The same property is assigned to two hard-coded nodes. This is already repeated for other fields such as mcp_servers, application_ids, and tool_ids.
    • Consider a small helper or loop to reduce missed updates: 
      for node_index in (5, 10):
    node_data = data["nodes"][node_index]["properties"]["node_data"]
    node_data["dialogue_number"] = dialogue_number
    node_data["mcp_servers"] = application.mcp_servers
    node_data["application_ids"] = application.application_ids
    node_data["tool_ids"] = application.tool_ids
    • Hard-coded data["nodes"][5] / [10] is fragile if node order changes. If the workflow format allows it, resolve nodes by ID/type instead of index.

Suggested cleanup

dialogue_number = getattr(application, "dialogue_number", None)

for node_index in (5, 10):
    node_data = data["nodes"][node_index]["properties"]["node_data"]
    node_data["dialogue_number"] = dialogue_number
    # optionally set the other common fields here too

Tests to add

  • Application with valid dialogue_number
  • ApplicationVersion with valid dialogue_number
  • Missing / None dialogue_number
  • Invalid type/value
  • Workflow schema validation for nodes 5 and 10

Overall: the main immediate issue is the unused local variable and repeated direct attribute access. The main longer-term risk is whether dialogue_number is guaranteed, versioned, and schema-compatible for both application types.

Expand Down
Loading