Skip to content

fix: external retrieval auth switch display #7825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fit2cloudwxx merged 1 commit into from
Nov 11, 2026
Merged

fix: external retrieval auth switch display #7825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/views/knowledge-detail/external-retrieval/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ watch([knowledgeId, () => resourceApi.externalRetrieval], loadExternalRetrieval,
@change="handleSettingChange('enabled', $event)"
/>
</section>
<section>
<section v-if="setting.enabled">
<div class="mb-2">
<span>对话用户授权</span>
<span class="text-N600"> (开启后，仅允许授权的对话用户通过 APIKey 检索当前知识库)</span>

@shaohuzhang1 shaohuzhang1 Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff appears to be a Vue.js single-file component change. Here is an analysis:

Potential Issues & Observations:

  1. Missing Closing Tag in Diff Context: The diff only shows the opening <section> tag being modified. Ensure there is a matching </section> closer for this element. If the original code had nested elements or other siblings inside that section, confirm they are still correctly grouped within this v-if-controlled section.

  2. Reactivity Dependency: The condition setting.enabled relies on a reactive property named setting.

    • Ensure that setting is a defined reactive object (e.g., via reactive() or ref()).
    • Verify that handleSettingChange('enabled', $event) correctly updates setting.enabled to avoid UI desynchronization.

  3. UX Consideration: Hiding the entire authorization section (v-if="setting.enabled") when disabled means users won't see the description text explaining what "dialogue user authorization" does until they enable the main toggle. This might reduce discoverability. Consider disabling the inner controls instead of hiding the whole block if user education is important.

  4. No Syntax Errors in Changed Line: The syntax of v-if="setting.enabled" is correct for Vue 3.

Optimization Suggestion:
If setting is a large object, accessing .enabled directly is efficient. However, if you frequently access multiple properties from setting, consider destructuring or ensuring fine-grained reactivity if performance becomes an issue (though unlikely for simple visibility toggles).

Verdict:
The change is syntactically standard Vue 3 code. No critical bugs detected, but validate the closing tag and ensure the UX intent (hiding vs. disabling) matches requirements.

Expand Down
Loading