Skip to content

fix: system chat user token quota #7830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fit2cloudwxx merged 1 commit into from
Nov 11, 2026
Merged

fix: system chat user token quota #7830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/views/system/chat-management/users/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const chatUserQuery = computed<Dict<unknown>>(() => ({
}))

function formatQuotaUsage(tokenQuota?: ChatUser['token_quota']) {
if (!tokenQuota) return '-'
if (!tokenQuota) return '0 / 不限'
const used = formatTokenNumber(tokenQuota.used_tokens)
if (tokenQuota.quota_type === QUOTA_TYPE.UNLIMITED) return `${used} / 不限`
return `${used} / ${formatTokenNumber(tokenQuota.token_limit)}`

@shaohuzhang1 shaohuzhang1 Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main issue is semantic, not syntactic:

  • Missing quota data is being treated as “0 / 不限” (0 / Unlimited). !tokenQuota can mean the data is still loading, failed to load, or is genuinely absent. Rendering “0 / 不限” can falsely tell users they have unlimited quota and hide an error/loading state. Safer to keep '-', use a loading/error placeholder, or only return '0 / 不限' if the business rule explicitly defines “no quota object” as “zero usage, unlimited.”

  • Hardcoded localized text: '不限' is repeated. If the app supports i18n, use a translation key/constant instead. At minimum, extract a constant to avoid duplication.

  • Add tests for:

    • tokenQuota undefined
    • unlimited quota with used_tokens > 0
    • limited quota
    • possibly null at runtime if the API can return it

Suggested safer version:

const UNLIMITED_LABEL = '不限'

function formatQuotaUsage(tokenQuota?: ChatUser['token_quota']) {
  if (!tokenQuota) return '-' // or a loading/error placeholder

  const used = formatTokenNumber(tokenQuota.used_tokens)

  if (tokenQuota.quota_type === QUOTA_TYPE.UNLIMITED) {
    return `${used} / ${UNLIMITED_LABEL}`
  }

  return `${used} / ${formatTokenNumber(tokenQuota.token_limit)}`
}

If the new behavior is intentional, add a comment explaining that missing quota data means “0 used / unlimited,” and ensure callers only pass undefined in that specific case rather than during loading or errors.

Expand Down
Loading